Describe the bug
cylc-report-timings has a dependency on pandas and matplotlib. Running this command, even after installing cylc with the extra [all] dependency group still results in an ImportError as these two dependencies are not included.
Release version(s) and/or repository branch(es) affected?
master
Steps to reproduce the bug
pip install .[all]cylc report-timings fiveCylcError: Cannot import pandas - summary unavailable.Expected behavior
Not having to install modules manually.
Screenshots
Additional context
Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read CONTRIBUTING.md before starting any work though).
Good spotting. This was kind of deliberate in cylc-7 (but which I just mean, not listed as requirements) because the command is an outlier (nothing else in cylc needs these dependencies) ... but I suppose we should address that in cylc 8, or at least add a new installation category.
Should cylc report timings become a component of the new UI?
It should eventually, but we might need the simpler solution in the interim.
It should eventually, but we might need the simpler solution in the interim.
In that case, I think we can simply copy what was done for empy?
Creating a group like report-timings with a version of pandas and matplotlib that, when installed, allows cylc report-timings runs OK.
For the interim we should probably put the cylc report timings in the extras_require section.
@irvslyy I've deleted your previous two comments. Google Translate gives me some strange text in Indonesian. Sorry, but none of us - as far as I know - know much Indonesian (I could probably recognize the words with origin in Portuguese, but that's all). But if you could post in English it would be easier :+1:
I'll have a go at this :)
Most helpful comment
I'll have a go at this :)