Cyberchef: Bug report: Missing validation in "From Binary" option

Created on 22 Feb 2021  路  1Comment  路  Source: gchq/CyberChef

Describe the bug
Negative byte length in "From Binary" operation

To Reproduce
Steps to reproduce:

  1. Go to 'From Binary'
  2. Enter some binary text
  3. Set byte length to a negative value
  4. Wait
  5. See error

Expected behaviour
Problem in the src/core/lib/Binary.mjs. Loop iterator goes to wrong value, that causes wrong substring extraction

Screenshots
image

image

Desktop (if relevant, please complete the following information):

  • OS: Windows
  • Browser: Edge 88.0.705.74
  • CyberChef version: 9.27.3
bug
Source
picture yoyrandao

Most helpful comment

Thanks for raising this. I've fixed it both by preventing the user from entering a value lower than 1, and by adding a check in the function that throws an exception if the value is invalid. I also found a couple of other places that had the same issue so I've fixed them as well.

picture n1474335 on 22 Feb 2021
👍2

>All comments

Thanks for raising this. I've fixed it both by preventing the user from entering a value lower than 1, and by adding a check in the function that throws an exception if the value is invalid. I also found a couple of other places that had the same issue so I've fixed them as well.

n1474335 picture n1474335 on 22 Feb 2021
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

n1474335 picture n1474335  路  3Comments
wumb0 picture wumb0  路  3Comments
n1474335 picture n1474335  路  4Comments
farewell-ladmin picture farewell-ladmin  路  3Comments
nmantani picture nmantani  路  3Comments