Cxbx-reloaded: About - Contributors (Error)

[CakeLancelot]

Originally reported by @Mored1984
Copied from Cxbx-Reloaded/game-compatibility#846 (miscategorization)

Description

The text is not showing right, see the picture below.

Screenshots

Must be like the below picture

Additional Information

Why not show the names of patreon ?

[CakeLancelot]

To answer the question in the previous thread:

Why not show the names of patreon ?

They are shown under supporters, though the list has not been updated in some time.

Hopefully the GUI will be reworked soon in v0.2, which as far as I've heard is soon to start development.

[LukeUsher]

Feel free to submit a PR to address this: It's probably a line-ending issue (if the contributers file got saved as Unix line-endings instead of Windows, it won't render right by the dumb dialog).
Kinda shitty that it ended up going live like this, but it's not a big deal.

I'll probably do a 0.1.1 minor hotfix to address this when I get back from holiday. (Including making sure the list is accurate/up-to-date)

[RadWolfie]

I am unable to reproduce the issue with local compiled build on my Windows computer.

P.S. Even License tab has the same issue from AppVeyor builds, doesn't affect local compiled build through.

EDIT: Also can confirm the external contributors file is using Windows newline. And verified any edit/saved changes against git shows nothing been changed.

UPDATE: The issue came from AppVeyor's end since somehow it is saving the file as linux newline format instead of Windows' newline format.

Possible solution: Put .editorconfig file in the root directory. Then set both CONTRIBUTORS and COPYING files as Windows newline format (or other alternate method to support both linux and Windows).

[LukeUsher]

Rather than attempt to force appveyor to use a specific encoding, it would be better to update the GUI to not depend on encoding.

If you iterate through the string and convert LF to CRLF before rendering in the dialog, that will solve the problem.

Relevant code:
https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/blob/fc908b615b95ec34890eba3c28d9da416e37bed4/src/Cxbx/DlgAbout.cpp#L108

[ghost]

Fixed in #1369