Cxbx-reloaded: XInput to DirectInput needs restart

[Sarkie]

On a default install XInput is chosen.

Select DirectInput.

Configure DirectInput.

Game still won't take input.

You will have to restart the emulation to take the changes.

[PatrickvL]

Good spot!

[LukeUsher]

That's normal and has always been this case: Changing input mode requires a restart of the emulator and will until we implement support for dynamically adding/removing controllers at run-time. It's never been a supported feature, so it's not an issue.

A good feature request though ;)

[RadWolfie]

Restart emulator to take effect for configures is a bug. All changes done with configuration are suppose to take effect at next start of emulation.

@Sarkie, are you saying...
A) a restart of emulator is a requirement in order to accept the switch from XInput to DirectInput?
B) Or requirement to stop emulating the title then restart title to take effect the changes made, including XInput to DirectInput? (emulation)

If the answer is A), then it is a bug. Unless you say it is B), then it is normal.

until we implement support for dynamically adding/removing controllers at run-time.

This one I agree, if controller isn't turn on at start of the emulation. Then it will not accept any new controller. At least current code knows when not to take any input when connected controller is turned off. And still accept the same controller once re-connect. (This will be a different issue not relative to here.)

[PatrickvL]

To fix this, the m_ObjectConfig copy in the emulating process should be refreshed from the
m_ObjectConfig contents changed from within the configuration GUI.

[ergo720]

Closing, as this was a bug of the old input GUI where you had to select the proper input API. With the new one, all APIs will work in tandem so you don't have to switch between them.