Cxbx-reloaded: Correctly implement D3DDevice_GetViewportOffsetAndScale

[PatrickvL]

Currently, D3DDevice_GetViewportOffsetAndScale is implemented rather simple (it just sets all scale coordinates to 1.0 and all offset coordinates to 0.0).

To implement this correctly, we need to know a few test cases. Currently reported callers are:

• 007: From Russia with Love
• Army Men®: Sarge's War
• BeatDown - Fists of Vengeance
• Big Mutha Truckers
• Big Mutha Truckers 2
• Classified: The Sentinel Crisis
• Cold Fear
• Commandos SF
• Darkwatch
• Dr. Muto
• GTA: Vice City
• Jacked
• Madagascar
• Max Payne 2
• NBA LIVE 2005
• NFS: Underground
• NFS: Underground 2
• PoP: The Sands of Time
• Prince of Persia: T2T- see https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/pull/1109#issuecomment-386488587
• RPM Tuning
• Street Racing Syndicate
• Spongebob - Battle for Bikini Bottom
• The Incredibles: Rise of the Underminer
• The SpongeBob SquarePants Movie
• TMNT(R)2
• TMNT(R)3

TODO : Add more

Note : This has become more important now that we have a viewport scaling option

[Margen67]

Is this for games that show this error with, or without the viewport scaling hack enabled?

[PatrickvL]

It'll be needed both with, and without the viewport-scaling hack enabled (that hack won't alter triggering the popup anyway).

[JohnGodgames]

Army Men®: Sarge's War
Please report that Army Men®: Sarge's War™ shows this test-case: D3DDevice_GetViewportOffsetAndScale
In EmuPatch_D3DDevice_GetViewportOffsetAndScale (d:\cxbx-reloaded\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 3391)

BeatDown - Fists of Vengeance
Please report that BeatDown - Fists of Vengeance shows this test-case: D3DDevice_GetViewportOffsetAndScale
In EmuPatch_D3DDevice_GetViewportOffsetAndScale (d:\cxbx-reloaded\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 3391)

Big Mutha Truckers
Please report that Big Mutha Truckers shows this test-case: D3DDevice_GetViewportOffsetAndScale
In EmuPatch_D3DDevice_GetViewportOffsetAndScale (d:\cxbx-reloaded\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 3391)

Big Mutha Truckers 2
Please report that Big Mutha Truckers 2 shows this test-case: D3DDevice_GetViewportOffsetAndScale
In EmuPatch_D3DDevice_GetViewportOffsetAndScale (d:\cxbx-reloaded\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 3391)

Classified: The Sentinel Crisis
Please report that Classified: The Sentinel Crisis shows this test-case: D3DDevice_GetViewportOffsetAndScale
In EmuPatch_D3DDevice_GetViewportOffsetAndScale (d:\cxbx-reloaded\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 3391)

Cold Fear
Please report that Cold Fear shows this test-case: D3DDevice_GetViewportOffsetAndScale
In EmuPatch_D3DDevice_GetViewportOffsetAndScale (d:\cxbx-reloaded\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 3391)

Commandos SF
Please report that Commandos SF shows this test-case: D3DDevice_GetViewportOffsetAndScale
In EmuPatch_D3DDevice_GetViewportOffsetAndScale (d:\cxbx-reloaded\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 3391)

Darkwatch
Please report that Darkwatch shows this test-case: D3DDevice_GetViewportOffsetAndScale
In EmuPatch_D3DDevice_GetViewportOffsetAndScale (d:\cxbx-reloaded\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 3391)

Jacked
Please report that Jacked shows this test-case: D3DDevice_GetViewportOffsetAndScale
In EmuPatch_D3DDevice_GetViewportOffsetAndScale (d:\cxbx-reloaded\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 3375)

Street Racing Syndicate
Please report that Street Racing Syndicate shows this test-case: D3DDevice_GetViewportOffsetAndScale
In EmuPatch_D3DDevice_GetViewportOffsetAndScale (d:\cxbx-reloaded\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 3375)

SpongeBob SquarePants Battle For Bikini Bottom
Please report that SpongeBob SquarePants shows this test-case: D3DDevice_GetViewportOffsetAndScale
In EmuPatch_D3DDevice_GetViewportOffsetAndScale (d:\cxbx-reloaded\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 3375)

[blueshogun96]

I originally added this for Dr. Muto. I never did find out what a proper implementation would look like.

Shogun

[CakeLancelot]

Also got this message in 007: From Russia with Love:

Cxbx-Reloaded
---------------------------
Please report that FROM RUSSIA WITH LOVE (TM) shows this test-case: D3DDevice_GetViewportOffsetAndScale
In EmuPatch_D3DDevice_GetViewportOffsetAndScale (c:\projects\cxbx-reloaded\src\cxbxkrnl\emud3d8.cpp line 3391)
---------------------------
OK   
---------------------------

[ObiKKa]

This list in the OP is incredible. It's hard to search for the titles that have this issue in their issue pages because the notification messages usually only appear in screen snaps so you'd have to manually search for each issue in the game compat repo.

Found titles:
GTA: Vice City
Madagascar
Max Payne 2
NFS: Underground
NFS: Underground 2
PoP: The Sands of Time

I've searched through two pages' worth of the latest updated issues so I'm fairly confident these titles above are all that are left to add aside from future discoveries to be made by any tester.

[PatrickvL]

I think it's time to disable this popup - we've got more than enough test cases now

[ObiKKa]

It seems that this issue should have been a part of the Popup meta-issue from May 2018 onwards. But the latest PR link above (#1833) has solved this test case last February of this year.

[LukeUsher]

No longer relevant