Cwa-documentation: Wrong localization of "über die Corona-Warn-App"

Created on 26 Jan 2021  ·  24Comments  ·  Source: corona-warn-app/cwa-documentation

In the second statistics card, it says "über die Corona-Warn-App" in German, indicating that the warnings were transmitted through the app. This is incorrectly translated to English as "About":

https://github.com/corona-warn-app/cwa-app-android/blob/f82fbf7bd5634eb90f41434681fac82347d0d5d4/Corona-Warn-App/src/main/res/values-en/strings.xml#L1298

Other locales are probably also affected, at least they start with a capital letter while the German one doesn't. This issue is included in release/1.11.x and should probably be fixed before it is released.

This is where the string is placed, leading to confusion:

image


Internal Tracking ID: EXPOSUREAPP-4760

PR corona-warn-app/cwa-app-android#2219 merged 1.11

Fix 1.13 bug mirrored-to-jira ready-to-close

Most helpful comment

It will be good to check for the string statistics_card_submission_bottom_text in
https://github.com/corona-warn-app/cwa-app-android/blob/release/1.13.x/Corona-Warn-App/src/main/res/values/strings.xml before 1.13.0 is released to make sure it has been corrected and is showing "through the Corona-Warn-App".

All 24 comments

@fynngodau Thanks for the report. Internally tracked. Best wishes, DS


Corona-Warn-App Open Source Team
Internal Tracking ID: EXPOSUREAPP-4760

"via Corona-Warn-App" might also be used.

"About" is definitely wrong in that context.

Yes, this was apparently changed in corona-warn-app/cwa-app-android#2219

@fynngodau

I checked that the fix made it through to the 1.11.0 release and here's the screenshot showing the correct change highlighted:

Warnings by App Users

@MikeMcC399 Thanks for checking.
@fynngodau Thanks for reporting! Please close this issue.

This has been reintroduced for 1.12.0 here: https://github.com/corona-warn-app/cwa-app-android/commit/329e63645c1dd19c10fbbef032c8b6097c5cf410#diff-95947a64ab28cdf172d1825dd6723ec08f00ac9f4735da63071e92e5cba1f838R1294

@Bubu / @fynngodau

The string with id statistics_card_submission_bottom_text is also wrong in the release/1.13.x under development ☹️

https://github.com/corona-warn-app/cwa-app-android/blob/07dd578599e13e74de3162b251e448b8e02f66a5/Corona-Warn-App/src/main/res/values/strings.xml#L1460-L1461

"About" should be "through".

@MikeMcC399 Ok, thanks. Will forward info to dev/translation team.

Actually, this affects also iOS. @Ein-Tim could you cross-check, please?

@Ein-Tim Thanks.

@dsarkar Maybe transfer this issue to the documentation repo?

sure

Fix for iOS is in
https://github.com/corona-warn-app/cwa-app-ios/pull/1976/files#diff-8fc5b852f1f89c8368223b1ab28939b0b01f90542347b91e9bdb1e678b289dcaR1626 (English)

https://github.com/corona-warn-app/cwa-app-ios/pull/1976/files#diff-e13572933e789dbad0187272ddd37b7b9cc2579b2e3cf1e6e539e31703fd7fc1R1626 (Polish)

https://github.com/corona-warn-app/cwa-app-ios/pull/1976/files#diff-b3c3e7a727f9362c763edfcaa54d33dc62c9b20d10a648276505893201c15b0bR1626 (Romanian)

https://github.com/corona-warn-app/cwa-app-ios/pull/1976/files#diff-3babf2b882e3dc6610c48eec44e38674ce480317df9f13a2b848274df1ff05d5R1626 (Turkish)

https://github.com/corona-warn-app/cwa-app-ios/pull/1976/files#diff-ecbd40d7068f0f33db7723fca35a029aeb1c2f074bfdb46739735237711fd6e4R1626 (Bulgarian)

@Ein-Tim Thanks!

It will be good to check for the string statistics_card_submission_bottom_text in
https://github.com/corona-warn-app/cwa-app-android/blob/release/1.13.x/Corona-Warn-App/src/main/res/values/strings.xml before 1.13.0 is released to make sure it has been corrected and is showing "through the Corona-Warn-App".

@MikeMcC399 And probably also in the 1.14 branch before releasing 1.14 😉

The CWA Android 1.13.2 release is showing correctly:
"through the Corona-Warn-App" at the bottom of the "Warnings by App Users" statistics tile.

@MikeMcC399 Thanks for checking!
@fynngodau Thanks for reporting, would you like to close this issue?

@MikeMcC399 @dsarkar

Confirm fixed for iOS too

@Ein-Tim Thanks for cross-checking.

Then we can close this issue :)


Corona-Warn-App Open Source Team

Was this page helpful?
0 / 5 - 0 ratings