Cwa-app-android: First time contributors "Unauthorized" on CircleCI

[pr1metine]

Avoid duplicates

• [x] Bug is not mentioned in the FAQ
• [x] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
• [x] Bug is not already reported in another issue

Describe the bug

It appears that first time contributors are unable to pass the CI check which prevents them from merging pull requests into the dev branch. CircleCI will not carry out any checks because the user is "Unauthorized".

What's strange is that anyone on the master branch is allowed to be CircleCI checked. Thing is that you are bound to fail this check.

Expected behaviour

New contributors are authorized to use CircleCI for the dev branch and the CI check passes. This way the maintainers can merge the pull request.

Steps to reproduce the issue

Be a first time contributor

Fork this repository

Branch off and make some commits

Create a Pull Request to the dev branch

Technical details

• CircleCI
• dev branch

Possible Fix

Maybe there is an option to authorize anyone? Do something like the master branch?

Additional context

I have seen it happen with Pull Requests such as #683, its duplicate, #548, and my own #677 and #655 .

[tkowark]

Could you try to remove this line in the config.yml of your fork? And also the colon in the line before. Might be that the context is not accessible. If the build starts then, we'll have to remove the context and add the SONAR_TÒKEN as a separate instance variable in our builds...

[pr1metine]

Thank you @tkowark 🙏 . You def made my day.

I'll close this issue for now. Will the CI fix end up in production?

[pr1metine]

What about moving to GitHub Actions?

[tkowark]

Let's keep this issue open until that change finally made it into the master branch. Could you turn this into a separate PR?

[pr1metine]

Sorry for this necropost, this is what the CircleCI Support Engineer has to say:

Hi Thanh,

Thank you for getting back to me.

I looked again at the projects settings, and it appears the "Pass secrets to builds from forked pull requests" setting is disabled for that project.

Could you ask the Organization Admin to enable it? This should allow you to access the SonarCloud context.

Let me know if this helps.

Yann - Support Engineer - CircleCI

It might generally be that SonarCloud does not work with forked PRs because of said setting. But enabling this setting probably is a security hazard.