Cwa-app-android: Use android:inputType=textVisiblePassword for tan input edittext

Created on 31 May 2020  路  5Comments  路  Source: corona-warn-app/cwa-app-android

Feature description

Currently, android:inputType=text is used for the tan input edittext. This has the consequence that the user's soft keyboard shows suggestions and may save the TAN to a dictionary.

With android:inputType=textVisiblePassword, no suggestions are shown and the keyboard shouldn't save it in its dictionary.

Problem and motivation

The autocompletion of the softkeyboard may alter the TAN the user has typed in.

Is this something you're interested in working on

No

in progress

Most helpful comment

@jakobmoellersap thanks for the input. The change was trivial enough (1 line) to risk that ;)

All 5 comments

I'll pick that up

Just a suggestion, we should wait for verification on issues before doing PR's. Otherwise it could happen that your PR will not get into the codebase and you will have lost effort.

I am not saying your PR here is invalid or will not get confirmed.

@jakobmoellersap thanks for the input. The change was trivial enough (1 line) to risk that ;)

This looks like a sensible change to me, text suggestions should indeed not happen during tan entry we should accept this as a contribution.

fixed in #46

Was this page helpful?
0 / 5 - 0 ratings

Related issues

michaelwingender picture michaelwingender  路  3Comments

Magoli1 picture Magoli1  路  3Comments

marceljay picture marceljay  路  3Comments

FrankfurterRadler picture FrankfurterRadler  路  3Comments

MikeMcC399 picture MikeMcC399  路  3Comments