Currently, android:inputType=text is used for the tan input edittext. This has the consequence that the user's soft keyboard shows suggestions and may save the TAN to a dictionary.
With android:inputType=textVisiblePassword, no suggestions are shown and the keyboard shouldn't save it in its dictionary.
The autocompletion of the softkeyboard may alter the TAN the user has typed in.
No
I'll pick that up
Just a suggestion, we should wait for verification on issues before doing PR's. Otherwise it could happen that your PR will not get into the codebase and you will have lost effort.
I am not saying your PR here is invalid or will not get confirmed.
@jakobmoellersap thanks for the input. The change was trivial enough (1 line) to risk that ;)
This looks like a sensible change to me, text suggestions should indeed not happen during tan entry we should accept this as a contribution.
fixed in #46
Most helpful comment
@jakobmoellersap thanks for the input. The change was trivial enough (1 line) to risk that ;)