Cutter: The content of the Parsing tab in Hexdump should be Read-Only

[ITAYC0HEN]

Environment information

• Operating System: Any
• Cutter version: 1.12.0 master ad66718f375b013a3021e531891c71082ee48867
• Obtained from:
  
  
  
  • [x] Built from source
  
  
• File format: Any

Describe the bug

The "Parsing" tab in the hexdump view should be read-only as it only parses the selected bytes into different formats. Currently, the text box is editable and this can be confusing as people might think it can be used to patch bytes.

To Reproduce

The following gif demonstrates how to reproduce this issue.

1. Open a binary in Cutter
2. Open the Hexdump widget
3. Make sure that the sidebar is opened and "Parsing" tab is selected
4. Select few bytes in the Hex view
5. Choose the text box in the sidebar and start modifying the content shown

Expected behavior

The text box should be read-only

[hexagr]

Looking into this. QT supports read-only features including comboboxes. Will submit a PR when I get a successful build.

[hexagr]

I've just submitted a PR to make the parsing tab in the hexdump widget read-only.

[cctechwiz]

This issue appears to have been resolved in PR #2434, looks like it can be closed.

[ITAYC0HEN]

Good catch, thank you!