Cutter: Function summary displaying has bad disasm preview formatting (-monospace font)

Created on 12 Oct 2018  路  13Comments  路  Source: rizinorg/cutter

Work environment

| Questions | Answers
|------------------------------------------------------|--------------------
| OS/arch/bits (mandatory) | Windows 7 x64
| File format of the file you reverse (mandatory) | not related
| Architecture/bits of the file (mandatory) | not related
| Cutter and r2 version, See About Cutter (mandatory) | Version 1.7.2 / Using r2-2.9.0-310-gcb62c376b

Expected behavior

Function's summary Disasm preview and the tooltip in general have to look good and be easily readable

Actual behavior

Currently Disasm preview is not well formatted due to non monospace font is set. Some instructions don't fit the tooltip (see the second screenshot)

Steps to reproduce the behavior

  • Open some binary, make sure there any function in Functions view
  • Point the mouse on some non-empty function and wait for the tooltip appears

Examples:
image

image

BUG Enhancement UI good first issue

Most helpful comment

Yes, I know. Currently the work in progress and it looks like the following:
f91e66ff-70be-449f-80ea-0e5ee1226386

All 13 comments

In addition to the mentioned problems, there is no width limit for the tool tip. Whenever there's a long flag in the disas preview, the width of the tool tip will fit to the text. In some cases the tool tip was so width that it covered my two monitors.

I think the tooltip should not print the disassembly.
If you want a preview, just double click it and open it in disasm view.
(And I think removing it from the summary will solve this issue.)

@xarkes Why? it is good to have it... It saves the time, if a func is short and you don't have to click there to look at it.

@xarkes is it possible to get disasm preview colored?

It saves time, really? From my point of view, it's faster to click on it than waiting for the tooltip to appear.
I don't know if QToolTip supports html.

I could fix that, it does I think. How to get colored output of pdi 10 @ func_name?

I think you will need to use pdJ.

Is anyone working on this? And imo strings shouldn't be displayed in tooltip. Some functions have too many strings which makes tooltip height too big.

I鈥檓 working on it

Tooltip supports html, so i think a "pre" tag will format disasm preview same as it appears on console :)

Yes, I know. Currently the work in progress and it looks like the following:
f91e66ff-70be-449f-80ea-0e5ee1226386

Hey guys, the question:
Currently we could crop a tooltip specifying its max width, but in this case lots of long names are being cropped, usually cropped is useful part, and useless (sub.api_ms_win_crt_runtime_l1_1_0.dll__...) is left, so the information displayed on tooltip becomes less useful than it has to be...

image

Is there a way to get rid of these prefixes, at least for displaying in these tooltips?

Hi,
We are planning to remove it from any disas view to make the disassembly better, so I suggest you to keep it as it is now, and we will modify it once we managed to remove it from the disas widget.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

s0i37 picture s0i37  路  5Comments

0x913 picture 0x913  路  3Comments

Maijin picture Maijin  路  5Comments

hamsterwoede picture hamsterwoede  路  4Comments

Pamplemousse picture Pamplemousse  路  3Comments