Cutter: Enable X-refs in Strings panel and X-refs can not find strings

[dmknght]

Work environment

| Questions | Answers
|------------------------------------------------------|--------------------
| OS/arch/bits (mandatory) | Debian 10 amd64
| File format of the file you reverse (mandatory) | PE
| Architecture/bits of the file (mandatory) | i386
| Cutter and r2 version, See About Cutter (mandatory) | Version 1.7.2 / Using r2 3.0.0
| Show version information full output | https://pastebin.com/MSfrUAY6

Expected behavior

X-refs strings easily

Actual behavior

1. I have to double click on the string -> move string panel to disassembly panel, select string object in text field and use X-refs
2. Graph panel will display No function detected. Can not display graph. after panel move to disassembly panel.
3. Sometimes X-refs can not find string in functions
   

   Steps to reproduce the behavior

Tested binary file (This is a malware)
r.zip

Additional Logs, screenshots, source-code, configuration dump, ...

1. A string is called in main function
   
2. Search for that string in Strings panel
   
3. I have to move to disassembly panel to use X-refs
   
   X-refs can not find addr for this string
   
   (X-refs some other strings work good)
   

[xarkes]

I think the reason for that is the same as here: https://github.com/radareorg/cutter/issues/516

[dmknght]

Can you guys add X-refs to Strings panel? It would be a lot easier to find strings.

[xarkes]

Hmm you mean right click -> xrefs?

[dmknght]

Hmm you mean right click -> xrefs?

I think so. Because strings panel is using key filtering so i guess hotkey will not okay in here.

[ITAYC0HEN]

Ctrl+X?

[dmknght]

Ctrl + X is cool. But because Xrefs is using X as hotkey in other panel, so using Ctrl + X means user must remember 1 more hotkey :p.
P/s: Ctrl + X is cut text by default so maybe ctrl + x is not the best choice.

[ITAYC0HEN]

Right, makes sense :)

[dmknght]

I've had a new idea about X-refs: Sidebar has x-refs panel, but it shows many information. So if you guys create a stand-alone x-refs panel, user can put xref like this (sreenshot).

[xarkes]

Yeah I think it's quite a good idea, and easy to do.

[dmknght]

So I think click string object in string panel should show value in Xreft table too. I've tested and it worked for graph panel and disassembly only.

[xarkes]

Yeah that's probably because it's not the same signal sent/catched. In disas/graph it is likely "seekChanged" while in strings it's nothing (for now) afair.

[ITAYC0HEN]

Fixed in #817

[dmknght]

I've tested latest git version with binary file r.exe again. Some strings are not showing in xref. Turned out it is radare2's problem.

[Maijin]

@dmknght can you open an issue?

[dmknght]

I gonna open issue on radare2 repo after get information fully

[Maijin]

Yep ok thanks