Curriculum: Updates Needed in Javascript 7 - Object-Oriented Programming

[Reginatam429]

The code here was misleading based on the information given above and below it. The audiobook class should extend the book class: "class AudioBook extends Book". The paragraph above the example should also clarify that the audiobook class is a subclass of book.

class Book {
  ...

  calculateDueDate(borrowedDate) {
    return borrowedDate.setDate(borrowedDate.getDate() + 21);  // 21 days is 3 weeks
  }
}

class AudioBook {
  ...

  calculateDueDate(borrowedDate) {
    return borrowedDate.setDate(borrowedDate.getDate() + 14);  // 14 days is 2 weeks
  }
}

In addition, the tutorial link sends me to the H1 roadmap instead of a tutorial: "Go through this tutorial".

For FAQs on how to contribute, see: https://github.com/Techtonica/curriculum#volunteering

[bobbylcraig]

Hey @Reginatam429, I'll update this in two separate PRs. Looks like here they're probably referencing this tutorial.

I can adjust the wording and code above as well.

[bobbylcraig]

I've added two patches to the issues. I am concerned that the "Book" and "AudioBook" example isn't very clear (mostly because I'm not entirely sure this is an example that would play out in reality in this inheritance model...). If possible, I will try to remember to go back and update this with a more clear inheritance relationship. That's a big rewrite though.

[alodahl]

Hi @bobbylcraig and @Reginatam429 , thanks for pointing this out and for the fixes. Should we make another issue about a rewrite?

[bobbylcraig]

@alodahl Depends how pressing of issues y'all make into issues? If you can add a low priority to it, that might be best :)

[alodahl]

Yes, that’s fine @bobbylcraig, none of them are more pressing than this on the board. Would you mind making an issue since you know what’s missing?

[bobbylcraig]

@alodahl Will do!

[yagosansz]

Hi,
Is this issue still available? I would like to work on it!

[alodahl]

Sure thing, @yagosansz .
@lalpert , is this one of the files that has moved?

[lalpert]

@alodahl @yagosansz This file has not moved, but I did make significant changes to it recently.

[yagosansz]

@lalpert Are there any improvements or changes to be done? If so, would mind elaborating a bit more on it, please. =)
Thanks!

[lalpert]

@yagosansz sorry for the delayed reply. No more improvements needed that I know of. I just created this issue also related to OOP if you'd be interested in doing it: https://github.com/Techtonica/curriculum/issues/1075