Cura: [3.3.1] Crash when materials file does not contain a GUID.

[cooljing]

Application Version
Cura Version 3.3.1

Platform
Windows 7 64bit

Printer
FreeDMake v1.5(Custom Taiwan printer)

Steps to Reproduce

Actual Results

Expected results

Additional Information
I updated to Cura 3.3.1 .
But I always run into software crashes.
Everything works fine before I have loaded my old JSON file.
Since I put in the old JSON file, the software could not be opened.

The error message is as follows:

Traceback (most recent call last):
File "", line 969, in _find_and_load
File "", line 958, in _find_and_load_unlocked
File "", line 664, in _load_unlocked
File "", line 634, in _load_backward_compatible
File "__startup__.py", line 12, in
File "", line 969, in _find_and_load
File "", line 958, in _find_and_load_unlocked
File "", line 664, in _load_unlocked
File "", line 634, in _load_backward_compatible
File "Console.py", line 24, in
File "X:\3.3\build\inst\bin\cura_app.py", line 141, in
File "X:\3.3\build\inst\lib\python3.5\site-packages\cura\CuraApplication.py", line 652, in run
File "X:\3.3\build\inst\lib\python3.5\site-packages\cura\Machines\MaterialManager.py", line 107, in initialize
KeyError: 'GUID'

The log is as follows:

Thread 0x0000266c (most recent call first):
File "X:\3.3\build\inst\lib\python3.5\site-packages\UM\Backend\Backend.py", line 155 in _storeStderrToLogThread
File "threading.py", line 862 in run
File "threading.py", line 914 in _bootstrap_inner
File "threading.py", line 882 in _bootstrap

Thread 0x000018c4 (most recent call first):
File "X:\3.3\build\inst\lib\python3.5\site-packages\UM\Backend\Backend.py", line 147 in _storeOutputToLogThread
File "threading.py", line 862 in run
File "threading.py", line 914 in _bootstrap_inner
File "threading.py", line 882 in _bootstrap

Thread 0x000019b0 (most recent call first):
File "C:\Program Files\Ultimaker Cura 3.3\plugins\USBPrinting\USBPrinterOutputDeviceManager.py", line 66 in _updateThread
File "threading.py", line 862 in run
File "threading.py", line 914 in _bootstrap_inner
File "threading.py", line 882 in _bootstrap

Thread 0x000021d0 (most recent call first):
File "threading.py", line 293 in wait
File "threading.py", line 424 in acquire
File "X:\3.3\build\inst\lib\python3.5\site-packages\UM\JobQueue.py", line 86 in _nextJob
File "X:\3.3\build\inst\lib\python3.5\site-packages\UM\JobQueue.py", line 116 in run
File "threading.py", line 914 in _bootstrap_inner
File "threading.py", line 882 in _bootstrap

Thread 0x000003c4 (most recent call first):
File "threading.py", line 293 in wait
File "threading.py", line 424 in acquire
File "X:\3.3\build\inst\lib\python3.5\site-packages\UM\JobQueue.py", line 86 in _nextJob
File "X:\3.3\build\inst\lib\python3.5\site-packages\UM\JobQueue.py", line 116 in run
File "threading.py", line 914 in _bootstrap_inner
File "threading.py", line 882 in _bootstrap

Thread 0x00001f74 (most recent call first):
File "threading.py", line 293 in wait
File "threading.py", line 424 in acquire
File "X:\3.3\build\inst\lib\python3.5\site-packages\UM\JobQueue.py", line 86 in _nextJob
File "X:\3.3\build\inst\lib\python3.5\site-packages\UM\JobQueue.py", line 116 in run
File "threading.py", line 914 in _bootstrap_inner
File "threading.py", line 882 in _bootstrap

Thread 0x00001490 (most recent call first):
File "threading.py", line 293 in wait
File "threading.py", line 424 in acquire
File "X:\3.3\build\inst\lib\python3.5\site-packages\UM\JobQueue.py", line 86 in _nextJob
File "X:\3.3\build\inst\lib\python3.5\site-packages\UM\JobQueue.py", line 116 in run
File "threading.py", line 914 in _bootstrap_inner
File "threading.py", line 882 in _bootstrap

Thread 0x00002214 (most recent call first):
File "threading.py", line 297 in wait
File "zeroconf.py", line 1569 in wait
File "zeroconf.py", line 1153 in run 
File "threading.py", line 914 in _bootstrap_inner
File "threading.py", line 882 in _bootstrap

Thread 0x00002164 (most recent call first):
File "threading.py", line 297 in wait
File "zeroconf.py", line 1569 in wait
File "zeroconf.py", line 1017 in run
File "threading.py", line 914 in _bootstrap_inner
File "threading.py", line 882 in _bootstrap

Thread 0x00001308 (most recent call first):
File "zeroconf.py", line 946 in run
File "threading.py", line 914 in _bootstrap_inner
File "threading.py", line 882 in _bootstrap

Thread 0x00001408 (most recent call first):
File "threading.py", line 297 in wait
File "threading.py", line 549 in wait
File "C:\Program Files\Ultimaker Cura 3.3\plugins\UM3NetworkPrinting\UM3OutputDevicePlugin.py", line 274 in _handleOnServiceChangedRequests
File "threading.py", line 862 in run
File "threading.py", line 914 in _bootstrap_inner
File "threading.py", line 882 in _bootstrap

Thread 0x00000810 (most recent call first):
File "C:\Program Files\Ultimaker Cura 3.3\plugins\RemovableDriveOutputDevice\RemovableDrivePlugin.py", line 61 in _updateThread
File "threading.py", line 862 in run
File "threading.py", line 914 in _bootstrap_inner
File "threading.py", line 882 in _bootstrap

Current thread 0x00000ea0 (most recent call first):
File "X:\3.3\build\inst\lib\python3.5\site-packages\cura\CrashHandler.py", line 364 in _logInfoWidget
File "X:\3.3\build\inst\lib\python3.5\site-packages\cura\CrashHandler.py", line 214 in _createDialog
File "X:\3.3\build\inst\lib\python3.5\site-packages\cura\CrashHandler.py", line 82 in __init__
File "X:\3.3\build\inst\bin\cura_app.py", line 101 in exceptHook

[cooljing]

My JSON is here.
resources.zip

[ChrisTerBeke]

Seems like GUID is missing in one of your material config files?

[modem7]

Sounds like same issue as #3734 - I'm also missing guid in a material file.

[ChrisTerBeke]

Closing as it's not an issue with Cura itself (but rather with completely custom files).

[modem7]

For future reference for anyone who has issues with no guid in their custom material files, please use the following:

https://guidgenerator.com/

[fieldOfView]

Shouldn't Cura be able to handle this more gracefully? It did in previous versions apparently, so that would make this a regression.

[ChrisTerBeke]

Fair enough

[cooljing]

Thanks everyone~~~
I fixed this problem!!!
I remove the materials JSON file , and it can work.

[ChrisTerBeke]

Fixed in c13b77d8a19b59c66e20b77cbd1263ec9b5f4a74.

[Ghostkeeper]

That fix was undone here: https://github.com/Ultimaker/Cura/commit/ddc9da63b85644d62eb1ccb87180b0aaf2c546e2

And fixed in a different way here: https://github.com/Ultimaker/Cura/commit/f5a77071391f37d65f07d22e7bbd967cb706094e