Cudatext: Maybe add Find dialog option 'inc'?

[Alexey-T]

'inc' for incremental search (as you type).
currently 'inc' is 'embedded' into option 'Hi' (which means hilight all + incremental search).
better make 'inc' the separate button in the Find dialog?

[tmsg-gh]

Some may appreciate a separation into two though I personally would have both options on as default.

[Alexey-T]

Maybe new suggestion: change 'Hi' button to 3 states:

• Hi not pressed
• Hi pressed 1st time - incremental search is off
• Hi pressed 2nd time - changes title to "Hi++" - incremental search is on

[xcme]

What is "incremental search"? Is there a difference with "find next" mechanism?

[Alexey-T]

inc-search is embedded to 'Hi' option in tthe last beta. it is 'find-first' from 'initial caret pos', where 'initial carret pos' is remembered on Find dlg showing. (to reset it, hide dlg+ show dlg).

[xcme]

If we have focus on Search dialog, does it mean that for the main window current caret pos in on line 39?

[xcme]

If yes, why couldn't 'Hi' option use that position. I mean not that virtual remembered position, but real caret position?

[Alexey-T]

yes, gutter highlight shows that caret is there.

[Alexey-T]

why not use that? if Find dlg was shown with caret in line 39, it is used. if Find dlg was shown before with caret in line 10, line 10 is used.

[xcme]

OK, got it. I think now I understand the problem. Let me think about that.

P.S. I will be offline tomorrow, so if we don't get the solution for today, let's continue the discussion at the Monday.

[JairoMartinezA]

I don't know what more you want to change or add more features to search functionality in comparison with ST, but in my case, I knew ST first, so when I migrated to CudaText, I felt I lost some functionality. I know you are adding more features and that is OK, my comment is, if you try to replicate current ST behavior, that's will be enough for me. 👍

[Alexey-T]

yes I try to replicate it. but then I cannot enable 'select-all' together with inc-search. maybe will try more..

[xcme]

@JairoMartinezA, yes, that's about behavior like ST in regards to find/search mechanism. If you have time, check #3385 and #3422. In short, CT has unneeded scrolling in some case and solving that led to one side-effect which has to be solved as well.

[Alexey-T]

updated the beta- to make 'Hi' incremental-search be more like in ST. ie fixed the 'initial caret pos' for inc-search.
cudatext-win-x64-1.133.6.1b.zip

[xcme]

so when I migrated to CudaText, I felt I lost some functionality.

Same for me year ago, but now I think that CT is a bit better than ST if I agree to look the other way for some Lazarus glitches and some minor disadvantages like this search behaviour. But it should be solved soon and I even don't think to go back to ST :)

[Alexey-T]

@xcme
beta updated (see above), what is bad in current 'Hi' search? what is not like in ST in search? I am lost in messages

[xcme]

Now it's much better, but could you also fix this? This makes it difficult to check

[xcme]

Sorry, I'm disappeared for a while and lost the track a bit, but after that fix I don't see any difference with ST for the first glance.

[xcme]

1. Screen is not scrolled if has something on the screen (not sure if it was the root cause, possible the reason was in the 'find next' function)
2. It always search down, not from the top
3. It also doesn't remember last searched value, so not it doesn't move caret there with empty search line
4. Forgot what else to check

Seems fixed.

[Alexey-T]

so fixed, I will close this issue.