Cudatext: proposal: replace 3 find_suggest_ options with one

Created on 10 Jan 2021  路  5Comments  路  Source: Alexey-T/CudaText

  • find_suggest_sel
  • find_suggest_cur_word
  • find_suggest_in_selection

-->
replace with one "find_suggest" with string value:

  • if 's' in value: suggest selection
  • if 'w' in value: suggest current word
  • if 'i' in value: suggest option 'in selection'

OK? @kvichans @OlehL @dinkumoil @jairo-martinez

enhancement

Most helpful comment

@OlehL @Alexey-T
The description (not name) of new option must show which old options are replaced

if 's' in value: suggest selection (old "find_suggest_sel")
if 'w' in value: suggest current word (old "find_suggest_cur_word")
if 'i' in value: suggest option 'in selection' (old "find_suggest_in_selection")

Agree?

Dialog have filter to show both old and new options by finding in "name"+"description"

All 5 comments

I agree

OK

In general for last issues:

Explicit is better than implicit.

I agree with replace some options to one, but all new options must be simple and with the same structure.
All old options which will be joined, must be the same type (prefer to boolean type). The name for a new option must describe all old options (for current issue it can be find_suggest)
If can't to replace some options (for example with different types), it will be better to leave old options (at least for non-boolean types).

@OlehL @Alexey-T
The description (not name) of new option must show which old options are replaced

if 's' in value: suggest selection (old "find_suggest_sel")
if 'w' in value: suggest current word (old "find_suggest_cur_word")
if 'i' in value: suggest option 'in selection' (old "find_suggest_in_selection")

Agree?

Dialog have filter to show both old and new options by finding in "name"+"description"

see #3023. closing.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Alexey-T picture Alexey-T  路  4Comments

Alexey-T picture Alexey-T  路  7Comments

jczanfona picture jczanfona  路  5Comments

EchedeyLR picture EchedeyLR  路  3Comments

GHNewbiee picture GHNewbiee  路  7Comments