Cuckoo: "with a score of 10.6 out of 10!"

[jens1o]

My issue is:

Cuckoo is able to report scores greater than 10

My Cuckoo version and operating system are:

2.0.7 on Linux (Ubuntu 18.04.3 LTS)

This can be reproduced by:

Uploading a file (I cannot provide)

##### The log, error, files etc can be found at:
-

It might be worth max-ing the value before returning it

[doomedraven]

its alpha ;) and we are aware of that

[ryanbekabe]

Hi @jens1o,

You also can modify it with another number like 100/100 in core.
Find the core and fix it.

[jens1o]

@ryanbekabe https://github.com/cuckoosandbox/cuckoo/blob/edd432713934686748298d3c6ff7807d5a9efc87/cuckoo/core/plugins.py#L593

Should be changed to self.results["info"]["score"] = min(score / 5.0, 10)

[doomedraven]

PR it ;)

[ryanbekabe]

@jens1o

@ryanbekabe

https://github.com/cuckoosandbox/cuckoo/blob/edd432713934686748298d3c6ff7807d5a9efc87/cuckoo/core/plugins.py#L593

Should be changed to self.results["info"]["score"] = min(score / 5.0, 10)

Right. File 'cuckoo/cuckoo/core/plugins.py'.
For 'min(score / 5.0, 10)', Im not yet to try. Let's try!

[reox]

Not sure If you should just do the minimum, as more flags are more suspicious... but regardless of that, I got files with scores over 25 as well

[ThisIsNotMalware]

I thought of fixing it, but lets be serious, I love seeing 25,4 out of 10 VERY SUSPICIOUS