Cubicsdr: Issues with wxWidgets v3.11

[vsonnier]

This issue gathers the various problems encountered during the migration to wxWidgets v3.11: (checked when solved)

• [X] @Magalex2x14 : OS X 10.13.3, wxWidgets 3.1.1 - missing the labels on the buttons below the bookmarks. Same commit but with wxWidgets 3.1.0 - all OK.
• [X] @parkerlreed : Syntax incompatible with wxWidgets v3.04
• [X] @Magalex2x14 : OS X 10.13.3, wxWidgets 3.1.1 : improper BookmarkView refresh, forced by re-focus.
• [X] Windows 10 : very slow, blocking refresh of BookmarkView.
• [X] Windows 10: Buttons labels are invisible.

[vsonnier]

Solutions / Suggestions:

• @parkerlreed : The minimum requirement is wxWidgets v3.1, so you have to compile it from scratch, see the Wiki. The previous wxWidgets v3.0x syntax compatibility was pure luck, and had to end one day.
• @Magalex2x14 : Same story here on Windows 10. The custom text button color given from the current theme doesn't work well. I see if I can fix it, or else leaving the default color unchanged would do.

[Magalex2x14]

@vsonnier I also noticed that with 3.1.1 when new modem is added, corresponding buttons do not appear (bookmark, start recording, remove active). They appears only after "refocusing" - I have to click into the bookmarks or ranges, then back to the modems.

P.S. Hmmm. On same commit, but with 3.1.0 this issue is also present...

[parkerlreed]

@vsonnier Yeah I got the 3.1.1 installed fine but it had to be compiled which actually took quite a while. Not an issue for me personally but I can see that maybe being an issue when there doesn't appear to be a single distro shipping 3.1+. Appimage is one solution but even that has had issues as of late.

[parkerlreed]

(And by a long compile time it took nearly 8 minutes on a 4 core/8 thread machine running make at -j10. A bit lengthy and would only be longer for somebody running lower hardware)

[vsonnier]

@parkerlreed It is quite long indeed, but you have only to do it every 2 years given the super-slow wxWidgets release schedule.

I've pushed 1 commit on the master branch, which reverts most of the BookmarkView modifications... The control refresh is really slow here on Windows 10 with v3.1.1 vs 3.1.0, but is hopefully more correct.

Button foreground (i.e text color) has been forced to white (255,255,255) to stand out.

[MicroJoe]

wxgtk v3.1.x is shipped as binary release for Debian, Ubuntu and Fedora : http://codelite.org/LiteEditor/WxWidgets31Binaries

[parkerlreed]

Ahh thanks. Wonder why all the official repos seem to be behind (I guess due to compat with older software)

[vsonnier]

Hello @Magalex2x14, @parkerlreed and all. I've commited some changes on the master, which I believe fixes the following points:

• Invisible button labels (Windows, OS-X). I forced them to white instead of using the actual theme color.
• Slow BookmarkView refresh (Windows). Turns out the UI events were calling themselves back and forth.
• (Maybe ?) Improper control refresh (OS X). I've restored most of the old BookmarkView control logic, plus added other fixes.

Please tell me how it goes for you.

[Magalex2x14]

OS X. Invisible button labels are still invisible (maybe labels must be forced to black? White labels becomes visible when the button is pressed...) In the rest everything seems OK.

[vsonnier]

Thanks @Magalex2x14. Funny thing, colors are exactly inverted on Windows 10:

So finally in the last commit I removed the buttons custom colors. Less sexy, but should be OK on all platforms.
What about your UI refreshing problems ?

[Magalex2x14]

Everything looks good. I do not see any problems with the UI.

[vsonnier]

Great ! Thanks for your input, I think we can close this issue then.