Cssnano: background-image

Created on 4 Sep 2019 · 8Comments · Source: cssnano/cssnano

input：
background: url('https://ss0.bdstatic.com/70cFuHSh_Q1YnxGkpoWK1HF6hhy/it/u=508387608,2848974022&fm=26&gp=0.jpg?imageView2/1/w/750/h/1334');

output：
background: url('https://ss0.bdstatic.com/70cFuHSh_Q1YnxGkpoWK1HF6hhy/it/u=508387608,2848974022&fm=26&gp=0.jpg?imageView2%2F1%2Fw%2F750%2Fh%2F1334');

/->%2F

bug

Source

zhangchao828

All 8 comments

background: url("https://ss0.bdstatic.com/70cFuHSh_Q1YnxGkpoWK1HF6hhy/it/u=508387608,2848974022&fm=26&gp=0.jpg?imageView2/1/w/750/h/1334");

⬇️

background: url(https://ss0.bdstatic.com/70cFuHSh_Q1YnxGkpoWK1HF6hhy/it/u=5083876082848974022&fm=26&gp=0.jpg?imageView2%2F1%2Fw%2F750%2Fh%2F1334=);

This looks safe.
Whats the issue !?

@evilebottnawi I guess its good to close now

anikethsaha on 14 Nov 2019

/cc @anikethsaha
It is bug, https://tools.ietf.org/html/rfc3986#section-3.4, / and ? allowed in URL, we should fix it

alexander-akait on 14 Nov 2019

yeah but whats wrong if we are transforming them to safe codes like % ?

hhh......maybe the URL might get change. 😕

anikethsaha on 14 Nov 2019

@anikethsaha

yeah but whats wrong if we are transforming them to safe codes like % ?

There may be very different servers settings so better keep them as is. Also it is less css

alexander-akait on 14 Nov 2019

👍1

Should be easy to fix, you can try to fix it

alexander-akait on 14 Nov 2019

Should be easy to fix, you can try to fix it

yeah we need to just leave it as it is right?...no need of any transform.

anikethsaha on 14 Nov 2019

yeah we need to just leave it as it is right?...no need of any transform.

yes

alexander-akait on 14 Nov 2019

🚀1

@anikethsaha

yeah but whats wrong if we are transforming them to safe codes like % ?

There may be very different servers settings so better keep them as is. Also it is less css

yes

zhangchao828 on 15 Nov 2019

Was this page helpful?

0 / 5 - 0 ratings