Crystal: Suggestion: move some Complex’s instance methods into Math module

[cristian-lsdb]

Some Complex’s methods have the same name as Math’s methods, so the syntax of calling mathematical methods depends on the type:

Math.sqrt(2)           # Ok with Int
Math.sqrt(2.0)         # Ok with Float 
Math.sqrt(2.0 + 1.0.i) # Error with Complex
(2.0 + 1.0.i).sqrt     # Current syntax for Complex

I think it would be better to have the same namespace for all mathematical methods.

These methods have their Math counterpart:
Complex#exp => Math#exp(value)
Complex#log => Math#log(value)
Complex#log2 => Math#log2(value)
Complex#log10 => Math#log10(value)
Complex#sqrt => Math#sqrt(value)

[bcardiff]

I think is fine to add overloads for those methods in Math module to handle complex numbers.

[cristian-lsdb]

You think it’s better to move them, which will lead to a breaking change, or to create aliases? Moving them seems more logical to me because Int and Float don’t have these instances methods.

[asterite]

I think we should copy Ruby. These methods only exist in Math so in my opinion we should do the same.

[bcardiff]

Keeping them only in the Math module is a breaking change that we can tolerate right now I think. A PR is welcome in that direction.