Crystal: Wrong version inside alpine images for 0.33.0

[sdwolfz]

:warning: The 0.33.0 alpine images report version 0.32.1 :warning:

• docker run --rm -it crystallang/crystal:0.33.0-alpine-build crystal --version

Crystal 0.32.1 [41bd18fbe] (2019-12-18)

LLVM: 8.0.0
Default target: x86_64-unknown-linux-musl

• docker run --rm -it crystallang/crystal:0.33.0-alpine crystal --version

Crystal 0.32.1 [41bd18fbe] (2019-12-18)

LLVM: 8.0.0
Default target: x86_64-unknown-linux-musl

:heavy_check_mark: The non alpine one reports the right version. :heavy_check_mark:

• docker run --rm -it crystallang/crystal:0.33.0 crystal --version

Crystal 0.33.0 [612825a53] (2020-02-14)

LLVM: 8.0.0
Default target: x86_64-unknown-linux-gnu

[bcardiff]

Thanks for reporting. I've just updated the 0.33.0-alpine and latest-alpine docker images.

[straight-shoota]

Any idea why it was wrongly tagged?

[bcardiff]

Because the target in the makefile to copy the tar.gz is not phony, or because I didn’t do a make clean. :-)

I already update the release checklist with that info.

[sdwolfz]

Tried them out again and the versions are correct, thaks for the fix! 👍

[straight-shoota]

Should we add some kind of validation for this? For example verify that crystal --version contains the version part of the docker tag before publishing the image.

[bcardiff]

The ubuntu images have those validation. The alpine images are new and there are no steps in the crystal-dist repo yet, so, I manually do those steps for this first version.