Now that we have JSON::Serializable
and YAML::Serializable
I think we should remove JSON.mapping
and YAML.mapping
as usual: first deprecate them (warning), then remove them.
I believe the Serializable
approach is superior:
mapping
will generate getters and setters too, from which you can opt-out, but it feels a bit messy)mapping
you need to specify the type of instance vars, and you have to do this if you have multiple mapping
s (like JSON
and YAML
in a single class)mapping
doesn'tI'd like to deprecate mapping
in 0.32.0 and remove it in 0.33.0.
It might be worth making extracting it to a shard and keeping it in the crystal-lang org for a little while.
If someone want's to preserve this in a shard, this is fine. But I don't think we should burden crystal-lang with it.
Maybe the crystal-community would be a good place.
This seems like something that people might want for compatibility for a while. It does not seems like something that was inherently done wrong. I just thing it might be worth preserving for people keeping up with crystal releases and some people might prefer it.
Yes as a shard but not inside the organization (it's fine in crystal-community though... I _think_).
Most helpful comment
If someone want's to preserve this in a shard, this is fine. But I don't think we should burden crystal-lang with it.