Crystal: Remove time related aliases in Int: year, month, day, second, millisecond, nanosecond

[j8r]

There are aliases related to time - the singular and the plural variant of Int#year, Int#month, Int#week, Int#day, Int#minute, Int#second, Int#millisecond and Int#nanosecond.

Note that Int#microseconds is only in plural

Related code: https://github.com/crystal-lang/crystal/blob/master/src/time/span.cr

Reference PR: https://github.com/crystal-lang/crystal/pull/6273

[asterite]

Note that I wanted to remove them but nobody liked that. So the direction should be the other one: we should add the singular names back (remove the :nodoc: from them, and add millisecond).

[Sija]

Submitted as #6297.

[ysbaddaden]

I'm neutral here, either solution is fine.

[straight-shoota]

Note that I wanted to remove them but nobody liked that.

There are 4 :+1: on #6273 but only 1 :-1:. Besides, only one other core member expressed an opinion - and that was neither in favor nor against it. So it's certainly not true that there was a strong opinion for keeping these aliases. In fact, it was only a single voice critizising the PR.

So please, let's have an open and friendly discussion about this topic.

I personally don't care much, and I'm fine with either solution. Maybe tending a bit towards removing the aliases, because they actually don't add much convenience.

[RX14]

I'd prefer to keep them.

[Sija]

This can be closed since #6297 has been merged.

[bcardiff]

Thanks @Sija