Crystal: 0.24.2 - error `String contains null byte` when running in path with non ASCII chars

[ZaWertun]

Error:

$ cd ~/Документы/Проекты
$ echo 'puts "123"' > test.cr
$ crystal run test.cr
String contains null byte
???
???
???
???
???
???
???
???

Error: you've found a bug in the Crystal compiler. Please open an issue, including source code that will allow us to reproduce the bug: https://github.com/crystal-lang/crystal/issues

All is ok:

$ cd /tmp
$ echo 'puts "123"' > test.cr
$ crystal run test.cr
123

[RX14]

I can reproduce this, but using a built compiler seems to make it go away. Investigating more...

[RX14]

Narrowed it down to this corruption: https://carc.in/#/r/3p2k

p "/home/rx14/Документы/Проекты/test.cr".gsub('/', '-')

"-home-rx14-Доку\xD0-ент\xD1-/Про\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000\u0000"

triggered by https://github.com/crystal-lang/crystal/blob/92c3d42315760c08bdeca9d414188bb633299d10/src/compiler/crystal/codegen/cache_dir.cr#L34

[RX14]

Looks like a duplicate of #5348, the fix for which didn't make it into 0.24.2.

[ZaWertun]

Thanks for investigation :)

[ZaWertun]

It's odd that old issue is closed and bug was still there in 0.24.2 release.

[RX14]

@ZaWertun 0.24.2 was released from a different branch with cherry-picked bugfixes. Unfortunately this bugfix wasn't cherry-picked for 0.24.2. Given how badly 0.24.2 seems to have gone I hope we don't do the same again.

[ZaWertun]

Ah, got it

[straight-shoota]

@RX14 This is really sad considering that you explicitly recommended to include #5348 in 0.24.2 :(

[asterite]

I always suggest to keep moving forward with breaking changes and releases in master and forget about hot fixes and bug fixes releases until we hit 1.0. It's simpler, and this kind of issues don't happen. But it seems they don't like it (I think everyone except Manas liked the old way)