Crud: Fake fields are double encoded

[chancezeus]

When using fake fields I assumed I would also be able to access them by casting them to object or array (as the $casts in the documentation suggests). However when I look at the data returned by my API the data still is a JSON string. When I look at the data in the database, the data appears to be double encoded (ie. a string of a json_encoded object), which breaks the $casts to object/array. Also inside the FakeFields trait, the attribute value is checked for being "is_object", but if you cast to array (per documentation) you should check for is_array (also), otherwise you get an error because json_decode expects a string but gets an array.

[chancezeus]

And another note, I actually used the video element as input for the fake fields, which actually resulted in triple encoded data in the database (this however might not be (easily) fixed)...

[jsiebach]

Same issue I had here: https://github.com/Laravel-Backpack/CRUD/issues/259

I had to use a setter/getter instead of casting.

[tabacitu]

HI guys,

Does a composer update fix it for you?
What version of Backpack\CRUD are you using, @chancezeus ?

Cheers!

[a2thek26]

This seems to still be an issue. It seems like the FakeFields trait is unnecessarily json_encode-ing fake fields. Additionally, CrudTrait is attempting to json_decode arrays, json, and objects. Assuming the goal would be to use the casts property and allow Laravel to do it's thing, seems unnecessary to do these other actions.

I have updated to the latest version.

[tabacitu]

Hi @a2thek26 - thanks for the feedback. Are you using FakeFields on a multi-language entity, or a single-language one?

Thanks, cheers!

[a2thek26]

@tabacitu Single language.

[hojabbr]

The double encoding of fake fields just ruined my whole project, I can't do any eloquent queries on the fake fields...

Not possible:
where('extras->key', 'value')

[f-liva]

Take a look to PR https://github.com/Laravel-Backpack/CRUD/pull/687

[hojabbr]

@fede91it When do you expect a merge?

[tabacitu]

@fede91it thanks a lot for the PR - it looks great. Let's move the conversation there please.