Cross-project-council: Fastify charter review

[mcollina]

Fastify is getting closer to completing its onboarding checklist.

Fastify charter is now ready to be reviewed by the CPC.

Let us know if there is something we need to change.

[eemeli]

Looks pretty good. I think a bit more clarity would be good regarding decision-making; it's clear that you have some internal structure in the team, with e.g. "lead maintainers" being defined, but I can't find any clarification on what that means for you. The Section 3 link to your CONTRIBUTING.md doc doesn't really help there, as that's just listing your GitHub teams.

Specifically, I'm left with these questions:

1. Who decides on things that are not charter amendments?
2. For charter amendments, do collaborators & past collaborators count for the required simple majority? They're both listed under the "Team" section of README.md, which is referred to as defining the "full FTM".

[joesepi]

Generally, I agree with @eemeli but approve of charter. Thanks.

[Eomm]

Working on it, I'll keep this issue posted 👍

[mhdawson]

I think ex. Node.js TSC Charter needs to be removed

[mhdawson]

I think it would also be good to have some info on how you can become a collaborator or a lead maintainer. Even if its as simple as a consensus of the existing lead maintainer or collaborators in each case.

If it's already in the repo somewhere, adding some links would work.

[SaraJo]

This looks great, congrats! I bet this is the result of a lot of hard work. I'm new, does the project charter need to be the same across projects?

Agreed with @mhdawson, I think telling people how to get involved in the charter would be great. For y'all, more hands hopefully make shorter work (not always, but usually).

Excited to see ya'll graduate.

[tobie]

The following sentence reads as a description of the OpenJSF where in fact it should describe the project itself (a project charter shouldn't be describing how the foundation operates):

The Fastify project is part of the [OpenJS Foundation][openjs foundation], which operates transparently, openly, collaboratively, and ethically.

Maybe change it to:

The Fastify project is part of the [OpenJS Foundation][openjs foundation]. It operates transparently, openly, collaboratively, and ethically.

Otherwise, this seems good to go!

[designMoreWeb]

This is fantastic I agree with @SaraJo, @mhdawson and @tobie on the changes. However we should have more clarity on how to get involved with Fastify. Other than that this is great 👍🏽

[mcollina]

However we should have more clarity on how to get involved with Fastify.

We have this page on the website: https://www.fastify.io/contribute/. I don't think the Charter is the place where to put clarity on how to get involved.

[mhdawson]

My comment was not really related to "how to get involved".

It's that the charter delegates responsibilities on people in certain roles (Lead Maintainers, Core team etc/.)

The issue in my mind is that the CPC is delegating responsibility to people in those roles within the Fastify charter, as such its important to understand how people join those roles. For example if anybody can join through a simple PR versus consensus of the existing members. I could not find info in the Fastify repo on how people become "Lead Maintainers" or part of the "Fastify Core team".

I don't think its necessarily more than a couple of lines of text somewhere in the Fastify docs. If its already there then just a reference to that would close the gap from my perspective.

[mcollina]

@mhdawson take a look at. https://github.com/fastify/fastify/pull/2501

[mhdawson]

@mcollina, made a few grammatical suggestions but looks good to me.

[joesepi]

Closing this as we seem to have consensus. Yay Fastify!