Create-react-app: Update testing-library packages for cra-template

[kentcdodds]

Describe the bug

The following package.json files need dependencies updated:

• https://github.com/facebook/create-react-app/blob/94932bedc09976aeac43615d95906aa2dcfefa1f/packages/cra-template/template.json
• https://github.com/facebook/create-react-app/blob/94932bedc09976aeac43615d95906aa2dcfefa1f/packages/cra-template-typescript/template.json

And the template code should be changed to use screen:

https://github.com/facebook/create-react-app/blob/8a1ee2f7a531d83cb76cc882d1e346c5cdd55f56/packages/cra-template-typescript/template/src/App.test.tsx

  import React from 'react';
- import { render } from '@testing-library/react';
+ import { render, screen } from '@testing-library/react';
  import App from './App';

  test('renders learn react link', () => {
-   const { getByText } = render(<App />);
-   const linkElement = getByText(/learn react/i);
+   render(<App />);
+   const linkElement = screen.getByText(/learn react/i);
    expect(linkElement).toBeInTheDocument();
  });

And the same treatment for this one:

https://github.com/facebook/create-react-app/blob/2de57fe15a69a84fadb08ce549599c7de5a9d3b2/packages/cra-template/template/src/App.test.js

I think the rest of the template is irrelevant.

[MichaelDeBoey]

In order to update the dependencies, the templates needs Node 10+.
Right now they're supporting Node 8 (cra-template) & Node 8.10 (cra-template-typescript).

https://github.com/facebook/create-react-app/blob/d2f813f8897ffcd2f0b0d2da75d0c44924c92f4d/packages/cra-template/package.json#L17-L19

https://github.com/facebook/create-react-app/blob/d2f813f8897ffcd2f0b0d2da75d0c44924c92f4d/packages/cra-template-typescript/package.json#L18-L20

[kentcdodds]

Ah yeah, it would be great if we drop node 8 so we can upgrade jest as well :)

[MichaelDeBoey]

Jest upgrade is happening in #8362

[MichaelDeBoey]

@ianschmitz Not all of this is done, so this one should be re-opened I think 🙂

[ianschmitz]

We won't drop Node 8 until v4, and will review/update all packages at that time.

[kentcdodds]

Sounds reasonable 👍