Create-react-app: CRA has unmet peer dependencies

[JeromeDeLeon]

Whenever I installed new CRA using npx, there are three unmet dependencies:

warning " > @testing-library/[email protected]" has unmet peer dependency "@testing-library/dom@>=5".
warning "react-scripts > [email protected]" has incorrect peer dependency "[email protected]".
warning "react-scripts > @typescript-eslint/eslint-plugin > [email protected]" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".

I saw related PR for making TS optional, but what about those two?
I tried deleting node_modules and even creating a new one, but still those warnings exist.

[stale[bot]]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[andrewmclagan]

I would bump this.

When using Yarn 2 (berry) and running npx @yarnpkg/doctor we receive:

/Users/.../app/package.json:42:36: Unmet transitive peer dependency on @testing-library/dom@>=5, via @testing-library/user-event@^7.1.2

[NMinhNguyen]

@kentcdodds do you think it's worth adding @testing-library/dom to the list of project dependencies? Technically speaking it's provided by @testing-library/react but not sure how else to get around this warning.

[kentcdodds]

I'd be fine with it personally.

[NMinhNguyen]

I'd be fine with it personally.

@kentcdodds fine with a dependency on dom? Or with the warning being there because it's harmless? 😅 The only main downside I can envisage is it might confuse users - they might wonder, "Do I import RTL or DTL?"

[kentcdodds]

I'm fine with the dependency. I doubt people would import the dom library directly.

[stale[bot]]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[NMinhNguyen]

Don't mark this as stale yet, would be good for #8155 to land first. It includes https://github.com/testing-library/eslint-plugin-testing-library/blob/master/docs/rules/no-dom-import.md to deter users from importing the DOM library

[stale[bot]]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[stale[bot]]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[NMinhNguyen]

8155 should be merged soon at which point this issue can be tackled (at least the testing library part)

[stale[bot]]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[stale[bot]]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[NMinhNguyen]

This is now dependent on #8963 instead.

[stale[bot]]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[stale[bot]]

This issue has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue.