Create-react-app: no-useless-constructor eslint rule with typescript false positive

[xaviergonz]

v3.0.0

There seems to be cases where eslint rule "no-useless-constructor" will give false positives when used with typescript

e.g.

  constructor(private readonly x: number) {}

That constructor is not really useless since it will assign the given parameter to this.x, so maybe consider dropping that rule for now for typescript?

[ianschmitz]

Yeah this seems like a bug. Do you mind opening an issue in the typescript-eslint repo and linking back here so we can track?

[ianschmitz]

Sorry just realized that the rule you linked is the ESLint rule right (sorry on phone). May be worth posting in typescript-eslint anyways as they may need their own version of the rule.

[ianschmitz]

Ignore me @xaviergonz, hard to debug from phone 😛.

It looks like there's already a typescript-eslint equivalent: https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/src/rules/no-useless-constructor.ts.

I'll fix this up and it will be part of our next release. Thanks for reporting!