Create-react-app: react-error-overlay slow?

Created on 21 Dec 2018 · 5Comments · Source: facebook/create-react-app

I was wondering if it is a known issue that react-error-overlay is very slow, I'm currently using a package that e.g. calls console.error a lot, and the fact that I'm using create-react-app means that the native console.error is overwritten (affecting this particular package).

So my main question: is this an issue with the react-error-overlay implementation of console.error being slow or should it be expected that it can't handle thousands of repeated calls compare to native console.error?

I'm surprised that console.error is hijacked, I didn't expect that (when I was looking into the issue).

Source

steabert

Most helpful comment

Hey, if no one is working on it I'd like to give a try to it. I'm basically in the same situation as @mohsinulhaq (original creator of #6098) – i'm using error-overlay-webpack-plugin to get react-error-overlay into my application. Since the app is pretty big (😞) the downloading/parsing of source map takes significant time and since it's blocking rendering of the actual error I would like to tackle it.

I agree it would make sense to show compiled stacktrace immediately until the sourcemaps are loaded.

What do you think?

jukben on 26 Jun 2019

👍2

All 5 comments

It is pretty slow right now, we're looking at making it faster. 😄

Timer on 21 Dec 2018

Has this been taken up yet? It would be great if compiled stacktrace is shown immediately after error until sourcemapped stacktrace is computed. Just like redbox-react.
Thanks.

mohsinulhaq on 28 Dec 2018

No, if you'd like to contribute you can send a PR!

Timer on 28 Dec 2018

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.