Create-react-app: Check Node version early

[gaearon]

We need to add better Node version checks. The current one doesn’t cover all requirements (like Node >= 8.9.0).

[vldmrkl]

@gaearon, are the checks supposed to be changed under engines in package.json files?

Do I understand it correctly? If yes, I'd be happy to contribute.

[zivkaziv]

Hey guys, is someone working on it? I'll be happy to contribute

[ianschmitz]

@zivkaziv there's #5482 and #5501 already it looks like. Thanks though!

[maximilianotulian]

Hey guys, this one is available? Regards!

[ianschmitz]

Hey @maximilianotulian yes this is available. You should be able to base your work on #5430. Sorry we lost track of this

[maximilianotulian]

Thanks @ianschmitz, I will give it a try

[ianschmitz]

Hey @maximilianotulian yes this is available. You should be able to base your work on #5430. Sorry we lost track of this

Sorry i meant #5501 @maximilianotulian

[nsisodiya]

@gaearon IMO, the pre-install script can check node version and exit if it doesn't find suitable node version.

[dmitrij-borchuk]

Hey, do I understand correctly the issue? Looks like you are not satisfied with the current version checker (NOT the node version itself)? I took a look into the PRs that was done here and all of them updating the node version. Only this one https://github.com/facebook/create-react-app/pull/5501/files improved version checker, but it was not approved. Could anybody tell me what was wrong with it (apart of yarn.lock in .gitignore)?

[elit-altum]

@ianschmitz Can I try this one? Would love to contribute here!

Seems like there is now a check for v10 for node here. Would you like to have specific warnings for other node versions like 8.9.0 etc. If I understand the issue correctly?

I think https://github.com/facebook/create-react-app/issues/9614 can also be looked at under a PR made for this issue.