Create-react-app: Option --use-pnp doesn't end up with Yarn Plug’n’Play mode

[saberone]

Is this a bug report?

Yes

Environment

macOS Mojave (10.14)

The npx create-react-app --info command doesn't work for me.

Steps to Reproduce

1. Install yarn 1.10.1
2. Run npx create-react-app testapp --use-pnp
3. Install yarn 1.12.0-20181002.1534 (nightly)
4. Run npx create-react-app testapp --use-pnp

Expected Behavior

No node_modules folder anymore (duh ;) )

Actual Behavior

node_modules folder was present with both stable yarn as nightly version.

[gaearon]

cc @arcanis

[arcanis]

Hey @saberone! You need Yarn 1.12+ (currently in rc) to use --use-pnp. Installing it should be quite easy, we have instructions on the website 🙂

@gaearon Do you think it would be worthwhile to detect Yarn's version and print a notice if the current version doesn't support PnP when --use-pnp is used?

[arcanis]

Wait I didn't see you tried with both the regular and nightly versions. Can you share:

• The output of both create-react-app commands (in particular the "yarn add v1.x.y" part)
• The way you installed Yarn
• The output of which yarn and which yarnpkg

Maybe the way it's been installed has an issue that prevents create-react-app from correctly picking up the right version? I know it uses the yarnpkg binary instead of yarn, so that might be a factor.

[Timer]

I assume this will be fixed via https://github.com/facebook/create-react-app/pull/5269. Let us know if it still isn't working (releasing in a few minutes)!

[saberone]

Yes it works correctly with yarn v1.13.0-20181002.2034. Sweeet! The speed of this thing is crazy ;)

[elken]

Not working for me on 1.13.0-20181006.0201.

node_modules is present and installConfig.pnp is missing from my package.json.

[bugzpodder]

I tested and it worked for me. Please file a new bug report if you are having difficulties.

[jimthedev]

@elken I had some trouble where the check for version was having problems with nightly build versions. the semver package was being used and the .xxxx was causing it to fail, thus failing the check.