Create-react-app: Minify Bundle Error in CRA2

[SCasarotto]

Is this a bug report?

Yes. When trying to build I receive the following error:

Failed to compile.

Failed to minify the bundle. Error: static/js/1.7292b262.chunk.js from Terser

After looking into this more it seems to be due to this package I am using (https://github.com/selvagsz/react-power-select). At this time I don't know if this is something that should be resolved in CRA or in that package. Have posted there as well but I want to share here in the case this is caused by something in CRA.(https://github.com/selvagsz/react-power-select/issues/51)

Did you try recovering your dependencies?

Yes

Yarn Version: 1.10.1

Which terms did you search for in User Guide?

Terminal Error links to:
"npm run build fails to minify"

Environment

System:
OS: macOS 10.14
CPU: x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
Binaries:
Node: 10.10.0 - /usr/local/bin/node
Yarn: 1.10.1 - /usr/local/bin/yarn
npm: 6.4.1 - /usr/local/bin/npm
Browsers:
Chrome: 69.0.3497.100
Safari: 12.0
npmPackages:
@tippy.js/react: ^1.0.0 => 1.0.0
react: ^16.5.2 => 16.5.2
react-dom: ^16.5.2 => 16.5.2
react-scripts: 2.0.3 => 2.0.3
npmGlobalPackages:
create-react-app: Not Found

Steps to Reproduce

(Write your steps here:)

Steps to reproduce:

1) npx create-react-app my-app
2) cd my-app
3) yarn add react-power-select
4) in /src/App.js add import { PowerSelect } from 'react-power-select'
5) yarn build

Expected Behavior

Build Success!

Actual Behavior

Failed to compile.

Reproducible Demo

See Steps Above. Blank project with that library in it.

[gaearon]

Did this work with [email protected]?

[SCasarotto]

Yep, was working before upgrading last night.

[Timer]

Example failing file: https://file-vibjneuykx.now.sh

[Timer]

Issue exists in Terser: https://github.com/terser-js/terser/issues/120

[Timer]

The fix appears trivial, so I hope it's released soon: https://github.com/mishoo/UglifyJS2/pull/1610/files#diff-230c53e13e3ee367aec7d49470eb42caR3464

[kzc]

The fix appears trivial, so I hope it's released soon

Unfortunately that's not the case. I reworded the comment to remove confusion: https://github.com/terser-js/terser/issues/120#issuecomment-426330910

Use inline=2 until this issue is addressed.

Alternatively, someone can ask the Tether project to alter their code slightly to avoid the Terser bug: https://github.com/terser-js/terser/issues/120#issuecomment-426418919. This corresponds to line 10061 in https://file-vibjneuykx.now.sh/

[Timer]

What kind of potential bundle increase are we talking about, do you have any numbers?

[Timer]

Cross posting excellent repro case so we can add it to our E2E, allowing us to safely opt back into default inline value instead of 2 (assuming we make this change).

function foo(node) {
    var traverse = function(obj) {
        var i = obj.data;
        return i && i.a != i.b;
    };
    while (traverse(node)) { }
}   

https://github.com/terser-js/terser/issues/120#issuecomment-426688286

[Timer]

This fix is out in 2.0.4! Please upgrade and test.

[SCasarotto]

Appears to work great! Really appreciate the help!