Create-react-app: Incorporate concept of rewiring config as an alternative of ejecting or forking react-scripts

Created on 5 Sep 2018  路  5Comments  路  Source: facebook/create-react-app

Is this a bug report?

(write your answer here)

No

First thank you for this awesome master piece, I really appreciate that work.

Though would like to ask you to incorporate the concept of rewiring config as promoted in:
https://github.com/timarney/react-app-rewired
(Unfortunately it's not maintained anymore)

For details please see here:
https://github.com/timarney/react-app-rewired#how-to-rewire-your-create-react-app-project

This way it would be super easy to add custom loaders for SASS, TypeScript, Inline SVGs, etc.

Related #99

Most helpful comment

This is definitely something that's important. Ejecting seems like such an unnecessary thing when its so easy to add in a 'rewire' hook into react-scripts - if FB wanted to do it.

All 5 comments

See reply in https://github.com/timarney/react-app-rewired/issues/162#issuecomment-418708200. Thanks!

Once a consensus is met, a proposal issue with most-common use cases would be great!

@Timer
Thank you for your quick answers.

Though I regret that this issue got closed that fast.
Is it really put in stone not adding rewiring?
I agree that it will produce all kinds off side effects, though I think it would be very beneficial on the other side too.

May I kindly ask to reopen this issue and see if it's of interest for the community at all?

I feel that this is a conversation best had in https://github.com/timarney/react-app-rewired/issues/162 because that's where the community's home is. We really want to accommodate the 90% use cases.

At current time, we can say pretty confidently that this decision of not adding rewiring is "set in stone"; we can probably revisit this in about a year, give or take.

Thank you for bringing this to our attention!

I see, you have already made a firm decision in this regard.

Actually I would love to have this conversation here, inside the official repo.
May I asked you how you get to the data of 90% use cases? Do you have surveys?
If so I would definitely like to participate 馃槃

This is definitely something that's important. Ejecting seems like such an unnecessary thing when its so easy to add in a 'rewire' hook into react-scripts - if FB wanted to do it.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

alleroux picture alleroux  路  3Comments

xgqfrms-GitHub picture xgqfrms-GitHub  路  3Comments

Evan-GK picture Evan-GK  路  3Comments

rdamian3 picture rdamian3  路  3Comments

Aranir picture Aranir  路  3Comments