Create-react-app: Move launch-editor logic to react-error-overlay

Created on 20 Aug 2018  路  1Comment  路  Source: facebook/create-react-app

Request

It would be awesome if we could move all react-error-overlay logic into the react-error-overlay package.

Reason

Currently it is not possible to use all features react-error-overlay without installing react-dev-utils.

Files that should be migrated:

Related

https://github.com/zeit/next.js/pull/4979#discussion_r211121346

Alternative

Solved by https://github.com/yyx990803/launch-editor/

As an alternative it would also make sense to move the react-dev-utils/launchEditor.js into its own package. The electron community might appreciate it.

Since there is already an open-editor package on npm this would be a great place. (https://github.com/sindresorhus/open-editor/issues/4)

proposal

Most helpful comment

There's already a published standalone package (with webpack middleware available):
https://github.com/yyx990803/launch-editor/

>All comments

There's already a published standalone package (with webpack middleware available):
https://github.com/yyx990803/launch-editor/

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Aranir picture Aranir  路  3Comments

wereHamster picture wereHamster  路  3Comments

oltsa picture oltsa  路  3Comments

fson picture fson  路  3Comments

DaveLindberg picture DaveLindberg  路  3Comments