Create-react-app: CSS build @keyframes minification (CRA - v2.0)
Hey guys.
Hope you are doing fine.
I have found a bug with minified css.
create-react-app is minified css keyframes to some associative names like a, b etc. End this is bad because the new version creates two chunks main and vendor and both would have minified keyframes in each file and they would cross and conflict...
version to reproduce: 2.0.0-next.3e165448.
current stable version 1.1.4 works as expected.
p.s: sorry for my English
Asfalot
All 3 comments
Do you have a repo? I can test it out in next branch. I've turned on safe-options in css-nano and hopefully this situation is handled as well.
bugzpodder
on 8 Aug 2018
I have found your improvement - https://github.com/facebook/create-react-app/commit/52449c34eedc53e50a2a159d38604ea7df5bd997
and you are totally right, I have added this option { cssProcessorOptions: { safe: true } } to react-scripts/config/webpack.config.prod.js locally and it works as expected
Asfalot
on 9 Aug 2018
Thanks for testing it out. A new build of 2.0.0@next was published with this change.
bugzpodder
on 27 Aug 2018
Related issues
godmar
路
130Comments
gabrielmicko
路
70Comments
xiaoxiangmoe
路
89Comments
rovansteen
路
192Comments
amuehl
路
79Comments
Most helpful comment
I have found your improvement - https://github.com/facebook/create-react-app/commit/52449c34eedc53e50a2a159d38604ea7df5bd997
and you are totally right, I have added this option
{ cssProcessorOptions: { safe: true } }toreact-scripts/config/webpack.config.prod.jslocally and it works as expected