Create-react-app: Improve untracked files message during eject

[ryouaki]

> react-scripts eject

? Are you sure you want to eject? This action is permanent. Yes
This git repository has untracked files or uncommitted changes:

  ?? .gitignore,  ?? app.js,  ?? bee/,  ?? package-lock.json,  ?? package.json,  ?? views/

Remove untracked files, stash or commit any changes, and try again.

npm version is 5.0.3

[gaearon]

Please follow the recommendation in the message.

Remove untracked files, stash or commit any changes, and try again.

For example you can run

git add .
git commit -am "Save before ejecting"

and then try again.

[viankakrisna]

I think the error message looks weird, what is it with all the ??

@ryouaki do you mind filling the issue template and tell us the terminal that you are using?

[gaearon]

@viankakrisna I think ?? is what Git outputs for untracked files. It does look confusing though. Maybe we should output something better.

[gaearon]

Let’s keep it open and think how we can improve this message.

[ryouaki]

@gaearon thank you, you help me .it work now.

[Dubes]

_edit_ new to contributing to OSS, let me know if you would prefer a PR instead.

how about:

Your working directory is not clean. This will make it hard for you to resolve any unintended consequences eject may have on your changes. Please use git status to verify the changed files, then either remove , stash or commit them before trying again.

Intention: Tell user what is the problem. Inform them why we are stopping. Tell them how they can check which files are stopping us. Give them a hint on how they can resolve it.

I used the word _working directory_ even though current git status uses _working tree_ as a personal preference, as I have seen some new users of git tend to get confused with the concept of tree.

I derived the context based on the discussion in PR 2090

[GabrielAmazonas]

Hi @gaearon! May I pick this one? Is anybody else working on it?
Big thanks in advance!

[Kobzol]

This should really be overridable.. I have a repo with several projects combined and ejecting doesn't affect all of them, it's tedious that you have to manually remove the untracked files even though you know that the ejection won't collide with them.

[LannyCodes]

@gaearon @ryouaki @viankakrisna I just commited to the github casually,it work!

[Virako]

echo "*" >> .gitignore
git commit -am "tmp"
npm run eject
git reset HEAD~1

[dustturtle]

why I got lots of file names not in the directory?