Create-react-app: Conditionally output serve instructions

[evenstensberg]

Is this a bug report?

No, Enhancement Request

Summary

If you've got serve already installed globally, asking users to install it becomes redundant.

Example:

Current Implementation

Current implementation is that the same instruction gets outputted, even though you'd have serve installed after running yarn build

Proposed

1. Check global prefix and where the users global folder is installed
2. Print stdout message if it doesn't exist

Use process.argv to map back to where the global folder is, or you could add global-prefix as a dependency.

https://github.com/facebookincubator/create-react-app/blob/a171d930641f513279b1c7ceaab1fa9bbbbbb896/packages/react-dev-utils/printHostingInstructions.js#L124-L131

---

Happy hacking :)

[gaearon]

I renamed because we have labels. Thanks for filing!

[OwenFlood]

I'd love to submit a PR for this, do you think that the redundancy is just the line for installing serve? Or is it the whole section mentioning serve?

[gaearon]

Will be fixed by https://github.com/facebookincubator/create-react-app/pull/2761.

[evenstensberg]

Nice @OwenFlood ! 🔥