yes
I followed the migration instructions.
Actually I first followed the instructions "How to turn my app into a Progressive Web App" because I had done this following the previous instructions some months ago. Then I ran npm start: app started up with no errors.
Then ran npm install --save-dev --save-exact [email protected]
App did not start, errors in console see below.
Nuked node-modules, ran npm i, then npm start. Still same errors.
App starts up
App hangs on startup. Messages in the console:
C:\Users\alex\apf2\node_modules\source-map\lib\source-map\source-map-generator.js:8 Uncaught Error: Cannot find module "."
at webpackMissingModule (C:\Users\alex\apf2\node_modules\source-map\lib\source-map\source-map-generator.js:8)
at Object.<anonymous> (C:\Users\alex\apf2\node_modules\source-map\lib\source-map\source-map-generator.js:8)
at Object.<anonymous> (C:\Users\alex\apf2\node_modules\source-map\lib\source-map\source-map-generator.js:400)
at __webpack_require__ (C:\Users\alex\apf2\webpack\bootstrap c96fbe2β¦:657)
at fn (C:\Users\alex\apf2\webpack\bootstrap c96fbe2β¦:85)
at Object.<anonymous> (C:\Users\alex\apf2\node_modules\source-map\lib\source-map.js:6)
at __webpack_require__ (C:\Users\alex\apf2\webpack\bootstrap c96fbe2β¦:657)
at fn (C:\Users\alex\apf2\webpack\bootstrap c96fbe2β¦:85)
at Object.defineProperty.value (C:\Users\alex\apf2\node_modules\react-error-overlay\lib\utils\getSourceMap.js:1)
at __webpack_require__ (C:\Users\alex\apf2\webpack\bootstrap c96fbe2β¦:657)
C:\Users\alex\apf2\node_modules\react-dev-utils\webpackHotDevClient.js:226 ./~/source-map/lib/source-map/source-map-generator.js
8:45-52 Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
Run these commands in the project folder and fill in their results:
npm ls react-scripts (if you havenβt ejected): [email protected]node -v: v7.10.0npm -v: 4.6.1Then, specify:
This is my app.
I really can't face reducing this big project. I would probably produce a lot of new errors instead :-(
I'm hoping that others run into the same error and maybe have a less complex app which is easier to reduce.
What I _did_ do is revert to "react-scripts": "0.9.5". Result: app starts without errors.
Upgrade to "react-scripts": "1.0.0": App errors out again.
Thanks for reporting. Will look later today!
also happens on my macOS Sierra notebook
If you'd like to dig into why this happens (or have a smaller repro case) Iβd appreciate it!
The update worked flawlessly in another project of mine so obviously this error has to do with project specifics :-(
@Timer might have more insight than me here.
Just cloned your project and upgraded react-scripts; I can't get this to reproduce.
Can you please push me a branch (or direct me to one) with this happening? Thanks!
Scratching my head...
This happens to me when using master.
I now nuked my entire project locally, cloned it from github, updated react-scripts to 1.0.0. And get the error again.
??
Anyway: thanks a lot for caring!
@Timer : do you also get this warning (which I get following the error):
./~/source-map/lib/source-map/source-map-generator.js
8:45-52 Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
Seeing this on a project of mine as well, which also uses storybooks. Made a repo that reproduces this on my machine: https://github.com/phillipj/create-react-app-v1-upgrade
OS: macOS v10.11.6
Node.js/npm: v6.10.3/v3.10.10
Steps made to create the project above:
$ create-react-app --scripts-version=0.9.5 .
$ getstorybook
$ npm install --save-dev --save-exact [email protected]
npm WARN [email protected] requires a peer of webpack@^2.2.0 but none was installed.
npm WARN [email protected] requires a peer of webpack@^2.2.0 but none was installed.
$ npm ls webpack
[email protected] /create-react-app-v1-upgrade
βββ¬ @kadira/[email protected]
βββ [email protected]
I do not get that warning, but I'm using yarn. Let me try again with npm.
Forgot to mention, I see this in the npm output when installing [email protected]:
βββ¬ [email protected]
...
βββ¬ UNMET PEER DEPENDENCY [email protected]
Ah, yes this replicates for me when using npm ... I wonder what's different.
Seems NPM is deduping the wrong package, but it shouldn't cause webpack to acquire the incorrect version...
package trees
Yarn:
Joes-MacBook-Pro:apf2 joe$ npm ls source-map
[email protected] /Users/joe/Desktop/temp/apf2
βββ¬ [email protected]
β βββ¬ [email protected]
β βββ¬ [email protected]
β βββ¬ [email protected]
β β βββ [email protected]
β βββ¬ [email protected]
β βββ¬ [email protected]
β βββ [email protected] deduped
βββ¬ [email protected]
βββ¬ [email protected]
β βββ¬ [email protected]
β βββ [email protected] deduped
βββ¬ [email protected]
β βββ¬ [email protected]
β β βββ [email protected] deduped
β βββ¬ [email protected]
β β βββ¬ [email protected]
β β βββ [email protected] deduped
β βββ [email protected]
βββ¬ [email protected]
β βββ¬ [email protected]
β β βββ¬ [email protected]
β β βββ¬ [email protected]
β β βββ¬ [email protected]
β β βββ [email protected] deduped
β βββ¬ [email protected]
β βββ [email protected] deduped
βββ¬ [email protected]
β βββ¬ [email protected]
β βββ [email protected] deduped
βββ¬ [email protected]
β βββ¬ [email protected]
β βββ¬ [email protected]
β β βββ [email protected] deduped
β βββ¬ [email protected]
β βββ [email protected] deduped
βββ¬ [email protected]
β βββ¬ [email protected]
β βββ¬ [email protected]
β β βββ¬ [email protected]
β β βββ¬ [email protected]
β β βββ [email protected]
β βββ¬ [email protected]
β β βββ [email protected] deduped
β βββ¬ [email protected]
β βββ¬ [email protected]
β βββ¬ [email protected]
β βββ [email protected]
βββ¬ [email protected]
β βββ¬ [email protected]
β βββ [email protected] deduped
βββ¬ [email protected]
β βββ¬ [email protected]
β βββ [email protected] deduped
βββ¬ [email protected]
β βββ¬ [email protected]
β βββ¬ [email protected]
β βββ [email protected] deduped
βββ¬ [email protected]
β βββ¬ [email protected]
β βββ [email protected] deduped
βββ¬ [email protected]
βββ [email protected] deduped
βββ¬ [email protected]
βββ [email protected] deduped
NPM:
Joes-MacBook-Pro:apf2 joe$ npm ls source-map
[email protected] /Users/joe/Desktop/temp/apf2
βββ¬ [email protected]
β βββ¬ [email protected]
β βββ¬ [email protected]
β βββ¬ [email protected]
β β βββ [email protected]
β βββ¬ [email protected]
β βββ¬ [email protected]
β βββ [email protected] deduped
βββ¬ [email protected]
βββ¬ [email protected]
β βββ¬ [email protected]
β βββ [email protected]
βββ¬ [email protected]
β βββ¬ [email protected]
β β βββ [email protected]
β βββ¬ [email protected]
β β βββ¬ [email protected]
β β βββ [email protected]
β βββ [email protected]
βββ¬ [email protected]
β βββ¬ [email protected]
β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β β βββ [email protected]
β β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β β βββ¬ [email protected]
β β β βββ [email protected]
β β βββ¬ [email protected]
β β βββ¬ [email protected]
β β βββ [email protected]
β βββ¬ [email protected]
β β βββ [email protected]
β βββ¬ [email protected]
β β βββ¬ [email protected]
β β βββ [email protected]
β βββ¬ [email protected]
β β βββ¬ [email protected]
β β βββ [email protected]
β βββ¬ [email protected]
β β βββ¬ [email protected]
β β βββ [email protected]
β βββ¬ [email protected]
β βββ¬ [email protected]
β βββ [email protected]
βββ¬ [email protected]
β βββ¬ [email protected]
β βββ [email protected]
βββ¬ [email protected]
β βββ¬ [email protected]
β βββ¬ [email protected]
β β βββ [email protected]
β βββ¬ [email protected]
β βββ [email protected]
βββ¬ [email protected]
β βββ¬ [email protected]
β βββ¬ [email protected]
β β βββ¬ [email protected]
β β βββ¬ [email protected]
β β βββ [email protected]
β β βββ¬ [email protected]
β β βββ [email protected]
β βββ¬ [email protected]
β β βββ [email protected]
β βββ¬ [email protected]
β βββ¬ [email protected]
β βββ¬ [email protected]
β βββ [email protected]
βββ¬ [email protected]
β βββ¬ [email protected]
β βββ¬ [email protected]
β βββ [email protected]
βββ¬ [email protected]
β βββ¬ [email protected]
β βββ [email protected]
βββ¬ [email protected]
βββ [email protected]
βββ¬ [email protected]
β βββ [email protected] deduped
βββ¬ [email protected]
βββ [email protected] deduped
Fix up in #2243
thanks guys, you are amazing!
[email protected] should be out with a fix.
Can you please verify it helps?
works like a charm :-)