Hello !
First of all thanks a lot for the upgrade and the hard work, create-react-app is completely awesome 馃槃 !
This issue was discovered when updating to [email protected]
On launching an empty app created with create-react-app, and using right/left arrow on the keyboard (when no overlay error is present) it logs an error in the console:
Uncaught TypeError: Cannot read property 'error' of undefined
at renderErrorByIndex (overlay.js:66)
at switchError (overlay.js:86)
at shortcutHandler (overlay.js:145)
at keyHandler (shortcuts.js:17)
I could reproduce this error on a new react project created with create-react-app, as well as old projects I upgraded.
For info, I'm on Mac OSX Sierra on Chrome 57.
I would be glad to send a Pull Request and work on this issue, if someone could give me some hints to what's actually happening on here !
Thanks! I鈥檒l take a look later today but if you find a quick fix send it our way.
Fixed in #2238
[email protected] should be out with a fix.
Can you please verify it helps?
Just upgraded to [email protected] on some of my projects, and it worked perfectly. Thanks a lot 馃檶 !
The fix doesn't seem to be working in [email protected]. I can see it's there, but when I look at the react-error-overlay package in my node_modules folder it has the correct version number (1.0.3), however, the fix is not present in the overlay.js file.
Oops, my fault. Will publish 1.0.4 soon.
Should be fixed in 1.0.4 (just published).
Most helpful comment
The fix doesn't seem to be working in
[email protected]. I can see it's there, but when I look at thereact-error-overlaypackage in mynode_modulesfolder it has the correct version number (1.0.3), however, the fix is not present in theoverlay.jsfile.