Create-react-app: RFC: Support for eslint-plugin-compat

Created on 4 Jan 2017 · 14Comments · Source: facebook/create-react-app

Recently I've been working on an eslint plugin called eslint-plugin-compat that lints support for API's by using the caniuse db. It seems there is demand from the community for this plugin. Wonder if it has a place in create-react-app. Would a PR for it be welcome?

Here's a demo of it in action

demo of plugin usage

Also planning to add integration with babel-preset-env and browserlist

proposal

Source

amilajack

👍8 🎉1

Most helpful comment

That's pretty cool. Let's take another look at this after #1249.

gaearon on 11 Feb 2017

👍2 🎉1

All 14 comments

That's pretty cool. Let's take another look at this after #1249.

gaearon on 11 Feb 2017

👍2 🎉1

Great! This actually works with the browserslist config in the package.json 🎉

https://github.com/amilajack/eslint-plugin-compat-demo/blob/master/package.json#L9

amilajack on 11 Feb 2017

Do you want to send a PR for this?

gaearon on 20 Jan 2018

Sure! I don't know how CRA internals work. Which .eslintrc should I change?

amilajack on 20 Jan 2018

https://github.com/facebookincubator/create-react-app/blob/next/CONTRIBUTING.md#package-descriptions

gaearon on 20 Jan 2018

Thanks. I'll start working on this

amilajack on 20 Jan 2018

How would polyfills work in something like CRA? Excited to see your PR.

Timer on 22 Jan 2018

There is also https://github.com/ismay/stylelint-no-unsupported-browser-features

stereobooster on 17 Apr 2018

👍1

Is there a way how to use this with create-react-app 2.0 nowadays?

ackvf on 5 Apr 2019

Is this being worked on? Can I open a PR for this?

morsdyce on 19 May 2020

I wanted to wait to implement better polyfill and babel interoperability to the plugin before making a PR for this. I'll respond here again once I've implemented it.

amilajack on 20 May 2020

How would polyfills work in something like CRA? Excited to see your PR.

It detects if you're using babel or TS and if you are, it assumes all ES APIs are polyfilled and lints only WebAPIs

amilajack on 28 Jun 2020

I wanted to wait to implement better polyfill and babel interoperability to the plugin before making a PR for this. I'll respond here again once I've implemented it.

@morsdyce The plugin should be good to implement now!

amilajack on 28 Jun 2020

@gaearon You last wrote on this 2 years ago. Would you still accept a PR for this? Or is CRA headed in another direction?