Create-react-app: Remove unnecessary logo.svg file from template.

Created on 23 Jul 2016  路  4Comments  路  Source: facebook/create-react-app

I think that having an image file on the project template is just cumbersome, since virtually every user will have to delete it.

Other famous CLI tools for creating projects (such as rails or ember-cli) also display images on the first welcome screen, but neither add the actual image file to the generated project.

Most helpful comment

The point was to demonstrate how importing images works in Webpack (which is not obvious to anyone who has never worked with it). I think people will try to use strings in src directly if they don't see this example, and will be frustrated that this doesn't work. Do you have an alternative way of explaining this pattern to users? Perhaps, some lint rules could help? Also, I'm curious: how often do you create new apps?

All 4 comments

I think it's less about showing a logo, and more about showcasing to a new user how they might be able to use images in React. Most of the template code is there for that purpose.

The point was to demonstrate how importing images works in Webpack (which is not obvious to anyone who has never worked with it). I think people will try to use strings in src directly if they don't see this example, and will be frustrated that this doesn't work. Do you have an alternative way of explaining this pattern to users? Perhaps, some lint rules could help? Also, I'm curious: how often do you create new apps?

(...) showcasing to a new user how they might be able to use images in React.
I think people will try to use strings in src directly if they don't see this example

Makes a lot of sense. You guys have convinced me =]

The point was to demonstrate how importing images works in Webpack (which is not obvious to anyone who has never worked with it).

Yes, I saw it first time after creating my first create-react-app!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

fson picture fson  路  3Comments

oltsa picture oltsa  路  3Comments

stopachka picture stopachka  路  3Comments

DaveLindberg picture DaveLindberg  路  3Comments

rdamian3 picture rdamian3  路  3Comments