Crc: "FATA Libvirt crc network is not active" triggered falsely by non-C locale

[fabiand]

with LC=de_DE:

[fabiand@seven ~]$ ~/go/bin/crc start -b ~/Downloads/crc_libvirt_v4.1.0.rc0.tar.xz 
crc - Local OpenShift 4.x cluster
INFO  Checking if Virtualization is enabled       
INFO  Checking if KVM is enabled                  
INFO  Checking if Libvirt is installed            
INFO  Checking if user is part of libvirt group   
INFO  Checking if Libvirt is enabled              
INFO  Checking if Libvirt daemon is running       
INFO  Checking if crc-driver-libvirt is installed 
INFO  Checking if Libvirt crc network is available 
INFO  Checking if Libvirt crc network is active   
FATA Libvirt crc network is not active 

with LC_ALL=C

[fabiand@seven ~]$ LC_ALL=C ~/go/bin/crc start -b ~/Downloads/crc_libvirt_v4.1.0.rc0.tar.xz 
crc - Local OpenShift 4.x cluster
INFO  Checking if Virtualization is enabled       
INFO  Checking if KVM is enabled                  
INFO  Checking if Libvirt is installed            
INFO  Checking if user is part of libvirt group   
INFO  Checking if Libvirt is enabled              
INFO  Checking if Libvirt daemon is running       
INFO  Checking if crc-driver-libvirt is installed 
INFO  Checking if Libvirt crc network is available 
INFO  Checking if Libvirt crc network is active   
INFO  Checking if /etc/NetworkManager/dnsmasq.d/crc.conf exists 
INFO  Extracting the Bundle tarball ...           
INFO  Starting stopped VM ... 
…

[fabiand]

/kind bug

[cfergeau]

virsh net-list can indeed be localized:

$ sudo virsh net-list --all
 Nom         État    Démarrage automatique   Persistent
---------------------------------------------------------
 crc-88lpx   actif   yes                     yes
 default     actif   yes                     yes

The check is trying to match active, which is not what we get here.
Using the libvirt API directly instead of parsing virsh output would avoid this particular issue.

[gbraad]

I suggest to detect de_DE and fr_FR and in that case skip the
pre-flight tests ;-P J/K

We need to review all pre-flight tests to only perform LC_ALL=C based checks

In future we might want to directly check this from the driver/via the API
However, this might result into issue with static compile and go-bindings.

On Fri, May 10, 2019 at 5:39 PM Christophe Fergeau
[e-mail] wrote:
>

virsh net-list can indeed be localized:

$ sudo virsh net-list --all

Nom État Démarrage automatique Persistent

---

crc-88lpx actif yes yes

default actif yes yes

The check is trying to match active, which is not what we get here.
Using the libvirt API directly instead of parsing virsh output would avoid this particular issue.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

--

Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]

[fabiand]

har har :)

That's a master-of-arts suggestion.
noter real solution would be to "export LC_ALL=C" ;)

[gbraad]

Suggesting to only document this as a known issue? ;-)

On Fri, May 10, 2019 at 6:00 PM Fabian Deutsch [e-mail]
wrote:

har har :)

That's a master-of-arts suggestion.
noter real solution would be to "export LC_ALL=C" ;)

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/code-ready/crc/issues/125#issuecomment-491233740, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAAOZWWHRDSLIDLJFAD43LPUVBSBANCNFSM4HMAQBEA
.

--

Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]

[gbraad]

@anjannath please have a look at this. Fixing this is priority...
Solve this in the Run and RunWithPrivilege... ?

[anjannath]

@gbraad Work was going on, addressed praveen's comment and Just pushed updates to PR #124

[gbraad]

OK. See you have a new function. The only problem I have with this is that
we might still run into this when using an exec function. For now, we will
see how this will go moving forward

On Mon, May 13, 2019 at 11:27 AM Anjan Nath [e-mail]
wrote:

@gbraad https://github.com/gbraad Work was going on, addressed
praveen's comment and Just pushed updates to PR #124
https://github.com/code-ready/crc/pull/124

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/code-ready/crc/issues/125#issuecomment-491663817, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAAOZUAPFQMKWZT6Q774Q3PVDN3LANCNFSM4HMAQBEA
.

--

Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]

[anjannath]

we might still run into this when using an exec function.

Right, we have to use the RunWithDefaultLocale for now when we are comparing the o/p from a command.

[gbraad]

Fixed with #123, 8030f9210e6375af20a1c9a5f7c2b2c738ee9cfe