Our windows tests related to storing files using our stream adapter are currently failing.
https://github.com/phalcon/cphalcon/runs/402909157#step:27:346
Looks like the file isn't closed after writing. Need to be investigated on a windows machine.
Could be Phalcon or unit test/codeception related.
I will see what I can find on Windows
@harm-smits thnx. You can use this branch https://github.com/phalcon/cphalcon/tree/4.0.x-ci-and-tests
We've update Codeception in that branch as well so please make sure you run composer.
Running vendor/bin/codecept run unit should show the issues. Any PR could be targeted to this branch as well. If you don't have time please let me know.
@ruudboon Could you please cherry pick codeception to the 4.0.x branch? So that we'll have only CI integration in the 4.0.x-ci-and-tests branch. Another advantage of this approach is to not block the rest of the changes by one single.
@sergeyklay It will involve some CI changes regarding env and db import as well. I'm not sure if we can easily separate this.
We forgot to close the adapter in our tests. Fixed now
Most helpful comment
We forgot to close the adapter in our tests. Fixed now