Cphalcon: Validation messages

[JABirchall]

Im not sure as to the reason behind this decision, but I feel that the validation messages for the included validators should be within the validators them selfs not the base class.

https://github.com/phalcon/cphalcon/blob/master/phalcon/validation.zep#L334-L360

This is a very minor issue and more of my ODD kicking in, just feel its better design to have each validator define its default message to allow for easier extension and reliable removal of validators.

[virgofx]

Agreed. PRs are welcome. This should be a pretty straightforward refactor.

[JABirchall]

I would if I knew how to work with zephir :P

[Jurigag]

Just clone repo, install zephir extension into phpstorm and code it and do pr. Nothing fancy really.

[JABirchall]

I feel this issue should stay open. @sergeyklay

[niden]

Closing in favor of #13855. Will revisit if the community votes for it, or in later versions.

[emiliodeg]

@niden can you assign me this?

[niden]

@emiliodeg all yours

[emiliodeg]

I've been working on this and I want to share with you my design to receive opinions before doing all the work

I use an advice property to warning message, to avoid confusion with Phalcon\Messages\Message

Some validators like Phalcon\Validation\Validator\File starts to work like a container and split the inside validations in new validatos like Phalcon\Validation\Validator\File\Size, Phalcon\Validation\Validator\File\MimeType, Phalcon\Validation\Validator\File\Resolution, etc

The main idea is to have a transparent transition. All current definitions will continue to work as they do now

[niden]

Resolved in https://github.com/phalcon/cphalcon/pull/14193

[JABirchall]

Thank you guys :)