Covid19india-react: Fixing react-hooks/exhaustive-deps warnings.

Created on 29 Mar 2020  路  7Comments  路  Source: covid19india/covid19india-react

Describe the bug
Would be great if we could fix the react-hooks/exhaustive-deps warnings shown in the console .

To Reproduce
Just open your console after npm I && npm start

Expected behavior
The console should be clear of these warnings.

Screenshots
Screen Shot 2020-03-29 at 8 14 54 AM

Additional context
Fixing this would mean reading up useEffect and how their dependencies work. Here's a nice little guide https://overreacted.io/a-complete-guide-to-useeffect/

Claimed

All 7 comments

@jeremyphilemon Can I take this issue ?

Happy to help with this. Have 5 components cleaned up so far.

@ssonal thank you :)

I'm gonna have to go with @vinay-thallam since he wanted to take the issue first!

Feel free to checkout the other available issues!

No problem. This was a great way to learn the code-base! Will help out elsewhere.

wow... You guys are awesome.
Sorry. got busy with other work. @ssonal If you have already made progress please go ahead.

@jeremyphilemon Thanks for the gesture.

@ssonal all yours :)

Fixed via #328

Was this page helpful?
0 / 5 - 0 ratings