Covalent: Feature Request: HTML message in Simple Dialogs

Created on 27 Jun 2017  路  9Comments  路  Source: Teradata/covalent

Feature Request

Would like to be able to use html strings as the message for the simple dialogs for the TdDialogService. Would allow use of bold () and line breaks (
) and others in the message.

ex

openConfirm(): void {
    this._dialogService.openConfirm({
      message: '<b>This</b> is how simple it is to create a confirm with this wrapper service.<br>br>Do you agree?',
      disableClose: true | false, // defaults to false
      viewContainerRef: this._viewContainerRef, //OPTIONAL
      title: 'Confirm', //OPTIONAL, hides if not provided
      cancelButton: 'Disagree', //OPTIONAL, defaults to 'CANCEL'
      acceptButton: 'Agree', //OPTIONAL, defaults to 'ACCEPT'
    }).afterClosed().subscribe((accept: boolean) => {
      if (accept) {
        // DO SOMETHING
      } else {
        // DO SOMETHING ELSE
      }
    });
  }
enhancement open for debate
Source
picture trevorsmiley
👍2

Most helpful comment

i wonder at what point we need to draw the line for "simple" dialogs, and just use the material dialog API for things like HTML templates https://material.angular.io/components/dialog/overview

picture kyleledbetter on 29 Aug 2017
👍3

All 9 comments

We can probably set it as innerHTML and sanitize it instead of as a string to support this.

emoralesb05 picture emoralesb05 on 27 Jun 2017

What's the status on this right now? I was looking for this feature but sad to see it's not available yet. Thanks in advance!

Octopixell picture Octopixell on 29 Aug 2017

i wonder at what point we need to draw the line for "simple" dialogs, and just use the material dialog API for things like HTML templates https://material.angular.io/components/dialog/overview

kyleledbetter picture kyleledbetter on 29 Aug 2017
👍3

You're completely right @kyleledbetter ;) I'll look at that instead!

Octopixell picture Octopixell on 30 Aug 2017

I think more complex dialogs should be built from the material dialog. The covalent docs should probably include a link to the material service though.

aciccarello picture aciccarello on 30 Aug 2017

I guess as @kyleledbetter mentions it's to decide how simple is "simple".
ie "_This_ is too complex" to be used in a simple dialog

trevorsmiley picture trevorsmiley on 30 Aug 2017

+1 on this. I really just want to embed a link in it.

jmsunseri picture jmsunseri on 30 Aug 2018

Keeping this open for debate if should add more functionality to "simple dialog"

jeremysmartt picture jeremysmartt on 6 Sep 2018

+1 on this.

webplease picture webplease on 4 Feb 2019
👎1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

chdanielmueller picture chdanielmueller  路  3Comments
trkbrkr2000 picture trkbrkr2000  路  5Comments
akrepon picture akrepon  路  3Comments
fxstein picture fxstein  路  5Comments
Enngage picture Enngage  路  3Comments