Courseplay: Horsch Slurry tank 21.000 refill issues

[bojanh66]

This tool have some issue with refill course.
I have a refill course near the field with and without Wait Point.
Without Wait Point, tractor will just drive the course without stopping at refill container.
With Wait Point, tractor will stop at Wait Point, but then wont continue even if its full.

If i use ingame default slurry tank, Joskin for example, it works without issues.

Is Horsch DLC having issues with CP ?

[Tensuko]

Did you set the right filltype on the 4th page ? (the up/down slider symbol)

[bojanh66]

Yes, yes, Farm silo load Slurry or Digestate.
Actually, i think this is the problem:
https://www.farming-simulator.com/mod.php?lang=en&country=us&mod_id=135293&title=fs2019

I tried to use Samson PG II 20 with Zunhammer Farmland Fix 15 and same issue, it just goes past refill trigger.

Does this mod have issue with CP ?

When i detached it and had only trailer on the refill course, it stopped and started to refill.

[Tensuko]

Oh okay I see.
Does it happen too if you use other attatches so can say its a general problem with those kind of configurations or just this specific one ?

[bojanh66]

Tested now with few default ingame attachers, same issue, it just drives past refill tank.
It detects it at first few seconds and says "Loading 0 of 20000" but then just continue.

Do you need some logs ?

[Tensuko]

Channel 1 and 2 with vanilla equipment.
But not sure when we take a look at it, but I mark it as a bug.

[bojanh66]

https://youtu.be/7TiLPUJEwEU

log.txt

[SteelRodent]

I had issues with this not working when I tried doing it with one of the Samson slurry spreaders, but that was a few months ago and I just assumed it wasn't implemented yet. It should work to refill it from the field tank (or what the heck it's called in the game), but it definitely has a problem with the towed tankers.

The Horsch sprayer also won't refill from the Horsch truck-tanker, from the same DLC - have to do it manually - but this works fine with CP in FS17. But last I tried using self-propelled sprayers in FS19 CP didn't like them, so haven't tried this in a while.

I have had CP automatically fill the vanilla potato seeder with fertilizer from the IT-runner tanker (26.23 mod on the modhub). So whether the problem is isolated to slurry or just Giants' tankers I can't say.

[Tensuko]

but this works fine with CP in FS17

This is rly no argument, pls stop bring this up.
CP6 was at some point rebuild and had to, else it still wouldn't run at all....

And as figured out, somehow it won't stop when load at the tank when got an attatchement.

[GeorgeEarslight]

https://youtu.be/7TiLPUJEwEU

log.txt

Can you log with channel 19?

[bojanh66]

Do you need channel 19 only or 1 + 2 + 19 ?

[GeorgeEarslight]

Do you need channel 19 only or 1 + 2 + 19 ?

Just 19

[bojanh66]

https://youtu.be/aG4C3WB6EZM

log.txt

[GeorgeEarslight]

Yes, as Tensuko said CP is checking if TD12 is able to fill and it's messing it.
I need to further read what's going on as there should be a check whether an implement is fillable so it can be skipped.

[Tensuko]

Thx @GeorgeEarslight for helping out. Much appreciate that.

[GeorgeEarslight]

@bojanh66 Could you try the fix and report, please?
I've only tested with the Samson and TD12.

[bojanh66]

I tried it now with same equipment as u did.
It will work only if i put Wait Point during refill course.
If there is no Wait Point, driver will not stop for refill.

[Tensuko]

@GeorgeEarslight your fix works perfectly! Thank you! You can push that and @pvaiko will (hopefully) make new release out of it :)

@bojanh66
you had to add a codline from George to try it, not only with the tool.
And I tell you this one too: There is no need of Waitpoints! I don't know who spread that nonsence arround, but waitpoints are for what they are named, to simply wait (and do some actions in specific modes....) but won't help for triggers! Else the trigger is noticed correctly or not. A Waitpoint won't change anything on that... Wait for the pushrelease, then you can try it with next version.

[bojanh66]

Oh im sorry, i didnt see he posted a codline.
Yea i know Wait Point is not needed on refill courses, but in this case, its just a temporary fix :)

[GeorgeEarslight]

@Tensuko I've already made a request #4572.
This might also fix #4144.

[Tensuko]

@GeorgeEarslight do you mind take a look into #4506 ?
I posted a summery and my latest experiments at the end in English.
Maybe you have an Idea about it...

[pvaiko]

Pull request merged, release built, thank you @GeorgeEarslight, I really appreciate your contributions.