Cosmos: Duplicate codes for linked list
there is data_structures/src/list/singly_linked_list, but there is also a code for same problem in data_structures/linked_list/
One of them ought to be removed.
FR4NKESTI3N
All 21 comments
Looks like this has been fixed
rucha174
on 8 Mar 2019
@rucha174 Sorry, I had written wrong file path. Both directories still exist in repo.
FR4NKESTI3N
on 9 Mar 2019
Is the filename correct?
rucha174
on 9 Mar 2019
@FR4NKESTI3N @rucha174 If either of you would like to resolve this issue, then by all means go for it! Make sure to reference this issue however.
arnavb
on 9 Mar 2019
I have sent a PR. Please review it.
rucha174
on 9 Mar 2019
Why is this issue still open ? @arnavb @rucha174
code-blooded
on 23 Mar 2019
@code-blooded The old directory isn't completely gone yet. We moved from one file to removing the whole directory, which is pretty much a duplicate of the other one.
arnavb
on 23 Mar 2019
@arnavb Still same code of linked list is seen in both the paths.
Is this issue still open?
nisarg1499
on 15 May 2019
@arnavb Hello! Should I make the required changes in the code?
rucha174
on 17 May 2019
under GSSoc i would like to contribute @AdiChat
nitashadhingra
on 1 Mar 2020
I want to contribute in it..I think I would be able to remove the duplicate directory.
shreeya13garg
on 23 Mar 2020
@shreeya13garg / @nitashadhingra One of you can create a PR and fix this.
arnavb
on 23 Mar 2020
I have removed the singly linked list from data_structures/src/list/singly_linked_list to remove duplicates. Should I push it on Github?
shreeya13garg
on 23 Mar 2020
I have cloned the cosmos repository and committed the changes i.e removing duplicate files now I need permission to push it on github
shreeya13garg
on 23 Mar 2020
My PR in which I have added the modified code-:https://github.com/shreeya13garg/cosmos_PR
If there is any error let me know.
shreeya13garg
on 23 Mar 2020
@shreeya13garg That isn't how you create a pull request. I think you should follow this guide and become proficient with git.
arnavb
on 24 Mar 2020
Can I take up this issue if it is still open ? @arnavb
hanzohasashi33
on 29 Mar 2020
@hanzohasashi33 Sure. All you have to do is delete the extra folder, basically.
arnavb
on 31 Mar 2020
Looks like there is no duplicate folder in data_structures/ for linked list.
hanzohasashi33
on 1 Apr 2020
Yeah, I have already solved it. This issue has been solved.
On Wed, Apr 1, 2020 at 9:11 AM Prasanna Venkatesh notifications@github.com
wrote:
Looks like there is no duplicate folder in data_structures/ for linked
list.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OpenGenus/cosmos/issues/3934#issuecomment-607009586,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMLBWJECFJYLAY62BZPXKLTRKKZWPANCNFSM4GT2YL5Q
.
shreeya13garg
on 2 Apr 2020
@arnavb, According to @shreeya13garg, this issue has been resolved, kindly close this issue. It will help others to focus on other pending issues. :smiley:
saviourcode
on 31 Jul 2020
Related issues
arnavb
·
3Comments
arthurlacoste
·
3Comments
ivanrein
·
4Comments
ruchirchauhan
·
4Comments
arnavb
·
3Comments
Most helpful comment
Yeah, I have already solved it. This issue has been solved.
On Wed, Apr 1, 2020 at 9:11 AM Prasanna Venkatesh notifications@github.com
wrote: