Cosmos: [Travis-CI] libgraph-1.0.2 generates compilation errors

[abdouskamel]

This is a(n):

• [ ] New algorithm
• [ ] Update to an existing algorithm
• [x] Error
• [ ] Proposal to the Repository

Details:

Hello everybody,

I noticed that libgraph-1.0.2 generates compilation errors in Travis-CI C build. Errors are of the type :

use of undeclared identifier 'FONTDIR'

You can check the build here. Maybe the person who added this library can check to fix this ?

[willnode]

Yeah libgraph is in travis.yml but I haven't sure why it's there.

Anyway why we use tests in first place? It's seems only configured for C++ only.

[InfiniteCoder]

@willnode Its work in progress. Build and test checks have to be applied to other languages as well.
@Mithilan16 Have a look at this issue 👀

[Mithilan16]

@willnode I'am aware of the FONT DIR error and have been looking for a solution but libgraph is required to compile a couple files in the cellular_automation directory

[InfiniteCoder]

@Mithilan16 This library hasn't been updated for almost 12 years now. Also, it tries to implement Turbo C graphics features on Linux. Given how much things have changed in Linux in last decade, I think probably it's an issue with one of the dependency getting updated.
I think it's just better to use OpenGL instead. Maybe these programs should be removed.

[Mithilan16]

@InfiniteCoder I can take care of that.This means that I will have to remove any program that requires SDL and graphics.h

[InfiniteCoder]

@Mithilan16 Yes, and if and when you do that, also remove that library and all it's dependencies from travis.yml 👍

[abdouskamel]

@Mithilan16 @InfiniteCoder Does SDL depends on libgraph ?

[InfiniteCoder]

@abdouskamel Thanks for noting that! SDL is independent of libgraph, they have no relation. @Mithilan16 You wouldn't have to remove SDL based programs. My bad 🤦‍

[thatguy227]

The makefile for c was incorrectly picking up .c files from the third_party folder.
This has been corrected.

[abdouskamel]

@thatguy227 You should mention this issue in your pull request.

[arnavb]

@abdouskamel Has this issue been resolved to your knowledge? I opened a new issue for this. #3311 I am going to close it now, since this already exists.

[arnavb]

@abdouskamel Update! I have opened #3363 which fixes this issue!

[abdouskamel]

@arnavb No, this issue hasn't been resolved yet. Thank you for your pull request.

[abdouskamel]

@arnavb I guess I can close it now ?

[arnavb]

@abdouskamel Yes, I would close it, as libgraph is no longer a problem for the c build.