Cosmos-sdk: gentx command does not error on 0 Amount

Created on 16 Dec 2020  ·  3Comments  ·  Source: cosmos/cosmos-sdk

Summary of Bug

Creating a gentx with 0 amount passes, and does not error until subsequent collect-gentxs command

Version

v0.40.0-rc5

Steps to Reproduce

gaiad gentx moniker --chain-id $chain-id
gaiad collect-gentxs

cc: @colin-axner


For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned
CLI client-ux good first issue

Most helpful comment

This is because the amount flag has a default value (100000stake). I think it'd be better if amount became an argument since it is required

All 3 comments

This is because the amount flag has a default value (100000stake). I think it'd be better if amount became an argument since it is required

This is because the amount flag has a default value (100000stake). I think it'd be better if amount became an argument since it is required

ACK 👍

This is because the amount flag has a default value (100000stake). I think it'd be better if amount became an argument since it is required

I very much agree with this. It is more correct and affects UX positively :+1:

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rigelrozanski picture rigelrozanski  ·  3Comments

fedekunze picture fedekunze  ·  3Comments

ValarDragon picture ValarDragon  ·  3Comments

kevlubkcm picture kevlubkcm  ·  3Comments

fedekunze picture fedekunze  ·  3Comments